GNOME Bugzilla – Bug 167799
[PATCH] "unresolved hostname" dialog never closes when using "try again"
Last modified: 2006-04-24 21:50:36 UTC
Distribution/Version: Mandrakelinux cooker This is a follow-up from Mdk bug http://qa.mandrakesoft.com/show_bug.cgi?id=12426 to reproduce : -change hostname to a non resolved hostname (hostname foobar) -run gnome-session -you'll get "unresolved hostname" dialog. -in another shell, add "foobar" to /etc/hosts -go back to "unresolved hostname" dialog and press "try again" -login continue but dialog doesn't disappear. Attached patch fixes the issue and another one in the IPV6 check (using g_strncasecmp (x, y, 0) isn't really useful..). GNOME 2.8 and 2.9 are affected
Created attachment 37638 [details] [review] Fix try again never disappearing and fix misuse of g_ascii_strncmp
+DUP 127358
*** Bug 127358 has been marked as a duplicate of this bug. ***
+Prio HIGH Confirmed. the dialogue does indeed disappear but reappears quickly. You cannot close the reappearing dialogue by selecting "Try again".
Comment on attachment 37638 [details] [review] Fix try again never disappearing and fix misuse of g_ascii_strncmp Looks fine to me, thanks
Thanks for submitting a good patch. Closing as per last comment. Mark: Please reopen if you have not comitted yet.
He has not committed yet; note that he marked it 'blocked by freeze.'
Ups - status of the patch is "accepted-commit_after_freeze" so I thought "it has been commited even after freeze". I looked up the Bugsquad docs but they do not tell you when to close bug tickets with patches.
this patch should probably be commited now
Committed.