After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167633 - [wavparse] div by 0 => crash
[wavparse] div by 0 => crash
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.5
Other Linux
: Normal blocker
: 0.8.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-16 18:56 UTC by Sebastien Cote
Modified: 2005-02-20 12:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Sample wav file with bps = 0 (9.01 KB, application/x-gtar)
2005-02-18 14:22 UTC, Sebastien Cote
Details

Description Sebastien Cote 2005-02-16 18:56:00 UTC
In function gst_wavparse_fmt(), wav->bps is set to a value from the
gst_riff_strf_auds structure. For some (incorrect) files, wav->bps will be 0. In
wavparse's loop and seek functions, the timestamp is divided by wav->bps so it
crashes.

I guess wav->bps should be set at a default value if it is 0, the timestamps
won't be good but at least the filter won't crash.

I'm using gst-plugins-0.8.5 but the same code is in the latest version.
Comment 1 Tim-Philipp Müller 2005-02-17 22:14:09 UTC
Do you have a small sample file or the beginning of a file that exhibits this
bug by any chance?

Cheers
 -Tim
Comment 2 Sebastien Cote 2005-02-18 14:22:11 UTC
Created attachment 37643 [details]
Sample wav file with bps = 0
Comment 3 Tim-Philipp Müller 2005-02-20 12:55:20 UTC
Should be fixed in CVS now, thanks.

Cheers
 -Tim