GNOME Bugzilla – Bug 167517
[PATCH] building a rpm from the cvs source failes
Last modified: 2006-01-27 17:50:37 UTC
I tried creating rpm's from cvs today, and I noticed that it failed to find gstreamer-faac... what should be gstreamer-plugins-faac... This patch fixes that (it is my first patch, so I don't know if it is correctly created, but I think it should work)
Created attachment 37507 [details] [review] patch
hmmm, in the end, i get this: Requires: gstreamer-plugins = 0.8.7.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libdl.so.2 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgstreamer-0.8.so.1 libgthread-2.0.so.0 libm.so.6 libpthread.so.0 libxml2.so.2 libxvidcore.so.4 libz.so.1 Obsoletes: gstreamer-xvid Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/gstreamer-plugins-0.8.7.1-root error: Installed (but unpackaged) file(s) found: /usr/lib/gstreamer-0.8/libgstdvdlpcmdec.so /usr/lib/gstreamer-0.8/libgstrfbsrc.so RPM build errors: Installed (but unpackaged) file(s) found: /usr/lib/gstreamer-0.8/libgstdvdlpcmdec.so /usr/lib/gstreamer-0.8/libgstrfbsrc.so so i think these files should be added to the patch also, will update patch...
Created attachment 37511 [details] [review] updated patch
Christian, care to look at this please?
Already merged the fixes for this in CVS. Thanks for the report.
i see the added files, but shouldn't the @USE_FAAC_TRUE@%post -n gstreamer-faac be @USE_FAAC_TRUE@%post -n gstreamer-plugins-faac
ah, your right. Fixed in CVS now :) thanks
these are some other missing files :) %{_libdir}/gstreamer-%{majorminor}/libgstautodetect.so %{_libdir}/gstreamer-%{majorminor}/libgstgconfelements.so %{_libdir}/gstreamer-%{majorminor}/libgstcairo.so %{_libdir}/gstreamer-%{majorminor}/libgstdivxdec.so %{_libdir}/gstreamer-%{majorminor}/libgstdivxenc.so %{_libdir}/gstreamer-%{majorminor}/libgstmpeg2enc.so %{_libdir}/gstreamer-%{majorminor}/libgstmplex.so %{_libdir}/gstreamer-%{majorminor}/libgstmusepack.so i think there are more, but i don't have the dependencies to try them
ok, please give a patch for these with needed @USE_ statements, as I don't have these which I why they have never been added
hmm, i don't know how to include those with @USE_, i just have a local patch that adds them to the list without dependencies... (what is wrong, i know, but i have installed a whole bunch of dependencies, so it works...). I guess someone who knows a bit more about spec-files should do this... perhaps uraeus at gnome dot org (random name from changlog) or some other people who changed the file in the past can do this?
Christian what's up with this?
Ping, Christian?
Not an issue with 0.10 spec files. Some of them might be speced already in latest 0.8 also. Closing as a wontfix.