GNOME Bugzilla – Bug 167446
Use icon theme for stock icons in Glider
Last modified: 2005-02-24 16:42:17 UTC
Providing GTK+ stock icons inside gtkrc is bad: those icons will override your icon theme option. The best way now is provide them as an icon theme. To do it you have to: 1. remove the line with "include \"iconrc\"" from gtkrc 2. delete from build and package iconrc and *png files 3. add and make installable the Glider icon theme attached Just for pleasure; Eventually force GTK+ to use 16x16 icons in buttons instead 24x24 scaled down to 22x22 :-( To do it just add in gtkrc "gtk-icon-sizes = \"gtk-button=16,16\"" Notes: The Glider icon theme provides only 16x16 and 24x24 versions of some GTK+ stock icons; the "Inherits=gnome" option is veri helpful :-). All those icons come from gnome-icon-theme. BTW *zoom*png are provided @ 16 and 24 pixels, even the 24 already exsist in gtk+, because it seems that providing only the version @ 16 pixels, it will be used for 24 too.
Created attachment 37486 [details] [review] A stupid diff showing the how to remove current icons :-)
Created attachment 37487 [details] The tar.bz2 package with icon theme. Makefile.am stuff needs to be provided :-(
*** Bug 167561 has been marked as a duplicate of this bug. ***
I think this is a reasonable request - Glider really shouldn't be specifying icons in the gtkrc. SmoothGNOME has it's own icon theme, which should incoperate the stock icons. However, I think Glider should just use the default icon theme.
I'm trying to remove the icon's from the gtkrc, and I see that gnome-icon-theme-2.9.91 contains blue stock_right.png, rather than the green ones. However, Epiphany is still using green icons. Does GTK+ 2.6 not use stock icons from gnome-icon-theme? Or how do we get access to those stock icons?
Link: take a look (maybe install and use it) to the icon theme in attachment #2 [details]. I'll provide more details if you need, by now I can't :-)
Oh I see. So the current structure of having <size>/stock isn't used by GTK+ yet? Okay, I just modified my SmoothGNOME icon theme with these changes. I'll make a new release for testing. For now I don't think Glider should use a separate icon theme though. These changes should be made to the gnome-icon-theme rather than a patch on top. The whole point of SmoothGNOME's icon theme is to apply changes I think should be pushed back to the stock icon theme. <quote> To do it just add in gtkrc "gtk-icon-sizes = \"gtk-button=16,16\"" </quote> That syntax looks odd to me. Why are we escaping the double-quotes?
Nevermind I see. You were escaping them inside your quotation. :-]
Okay, I can't seem to locate a blue stock_ok.png (which should be named gtk-ok.png according to the naming scheme in the sample icon theme provided. Do you know of one? Or do I need to ask Jimmac about it?
Stock icons have been removed from Glider, so the main point in this bug has been resolved. The icon size is a seperate issue that needs to be addressed more widely, so please file a new bug.