After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167213 - patch replaces all libgnome stuff by gtk (still using gconf and gnome-vfs)
patch replaces all libgnome stuff by gtk (still using gconf and gnome-vfs)
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Mikael Hallendal
Mikael Hallendal
Depends on:
Blocks:
 
 
Reported: 2005-02-12 23:23 UTC by Kristof Vansant
Modified: 2005-03-25 13:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
removes all gnome code except gconf and gnome-vfs (24.88 KB, patch)
2005-02-12 23:24 UTC, Kristof Vansant 		committed Details | Review

Description Kristof Vansant 2005-02-12 23:23:10 UTC 
Please describe the problem:
since libgnome and libgnomeui are going to be deprecated I replaced the code.
the new autogen.sh is mutch cleaner

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Kristof Vansant 2005-02-12 23:24:21 UTC 
Created attachment 37418 [details] [review]
removes all gnome code except gconf and gnome-vfs
Comment 2 Kristof Vansant 2005-03-04 12:35:42 UTC 
Forgot this:

Index: configure.in
===================================================================
RCS file: /cvs/gnome/devhelp/configure.in,v
retrieving revision 1.95
diff -u -r1.95 configure.in
--- configure.in        29 Jan 2005 09:30:55 -0000      1.95
+++ configure.in        4 Mar 2005 12:35:21 -0000
@@ -31,10 +31,9 @@
        gtk+-2.0 >= 2.2.0])

 PKG_CHECK_MODULES(LIBDEVHELP, [
-        gtk+-2.0 >= 2.3.1
-       libgnomeui-2.0 >= 2.2.0
-       gnome-vfs-2.0 >= 2.2.0
-       libglade-2.0 >= 2.0.0
+    gtk+-2.0 >= 2.3.1
+    gnome-vfs-2.0 >= 2.2.0
+    libglade-2.0 >= 2.0.0
 ])

 dnl ******************
Comment 3 Kristof Vansant 2005-03-04 12:50:23 UTC 
Again forgot something(gtk version must be higher):

Index: configure.in
===================================================================
RCS file: /cvs/gnome/devhelp/configure.in,v
retrieving revision 1.95
diff -u -r1.95 configure.in
--- configure.in        29 Jan 2005 09:30:55 -0000      1.95
+++ configure.in        4 Mar 2005 12:35:21 -0000
@@ -31,10 +31,9 @@
        gtk+-2.0 >= 2.2.0])

 PKG_CHECK_MODULES(LIBDEVHELP, [
-        gtk+-2.0 >= 2.3.1
-       libgnomeui-2.0 >= 2.2.0
-       gnome-vfs-2.0 >= 2.2.0
-       libglade-2.0 >= 2.0.0
+    gtk+-2.0 >= 2.6.0
+    gnome-vfs-2.0 >= 2.2.0
+    libglade-2.0 >= 2.0.0
 ])

 dnl ******************
Comment 4 Mikael Hallendal 2005-03-04 13:03:33 UTC 
Ah great, sorry for not replying earlier. Will hopefully have time to look into this soon, anyway, I've 
noticed the patch and will get around to look at it as soon as I get some time over. Thanks a lot!
Comment 5 Mikael Hallendal 2005-03-25 00:04:12 UTC 
Hi, the patch looked great, *very* sorry for the long delay, I simply have too
little time to properly maintain my projects at this moment :/
Comment 6 Mikael Hallendal 2005-03-25 00:42:04 UTC 
Just noticed a problem with the patch, you shouldn't remove the calls to
bindtextdomain and such. Also the call to gtk_set_locale() is not needed since
this is done by gtk_init.
Comment 7 Kristof Vansant 2005-03-25 13:17:02 UTC 
k thx for fixing it