After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167070 - items in yelp's left hand pane shouldn't auto-expand.
items in yelp's left hand pane shouldn't auto-expand.
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Shaun McCance
Yelp maintainers
AP2
Depends on:
Blocks:
 
 
Reported: 2005-02-11 14:02 UTC by John Crawley
Modified: 2009-09-22 01:48 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Simple fix (838 bytes, patch)
2005-11-07 23:02 UTC, Don Scorgie
none Details | Review
Updated patch (1.01 KB, patch)
2005-11-08 18:27 UTC, Don Scorgie
committed Details | Review

Description John Crawley 2005-02-11 14:02:45 UTC
Distribution/Version: JDS Rel3 B28

Using yelp 2.6

In yelp, navigate to a category that has expandable left-hand pane items.
Notice that as the user presses the <down> or <up> keys to move onto such
an item, that it auto-expands. This is not a good thing - if a user wants
to navigate from section 1 to 5 (for example), then they will have to 
move through all of the sub-sections of sections 1 to 4.

The items should only expand when the user presses the <+> key.
Comment 1 Brent Smith (smitten) 2005-08-23 22:38:01 UTC
I can verify this is still a problem in 2.11.1.  Marking NEW.
Comment 2 Don Scorgie 2005-11-07 23:02:56 UTC
Created attachment 54444 [details] [review]
Simple fix

This implements this (I think).  Can someone check to make sure its doing the
correct (expected) behaviour?  Thanks
Comment 3 Shaun McCance 2005-11-08 04:21:48 UTC
Do people often just read the heads of chapters without reading their content? 
With linearly-written documents, I would expect people to read mostly linearly.

I'm out of town, and I can't take much action on this at the moment.  Could
somebody check with usability about what behavior they think is best.

Don, your patch will basically just suppress expanding for top-level nodes.  So
selecting, say, section 5.2 would still expand out the items for sections 5.2.x.
 Actually, it surprises me that expand_to_path has the behavior it does.  It
doesn't seem to fit with the name.  Expanding to the parent is probably the
easiest solution, making sure not to choke on top-levels, of course.
Comment 4 Don Scorgie 2005-11-08 18:27:18 UTC
Created attachment 54475 [details] [review]
Updated patch
Comment 5 Don Scorgie 2005-11-08 18:34:35 UTC
Updated patch attached.

Adding usability keyword and cc'ing usability-maint as per Shauns request in
comment #3
Comment 6 Calum Benson 2006-04-26 17:16:06 UTC
Apologies for spam... ensuring Sun a11y folks are cc'ed on all current accessibility bugs.
Comment 7 Calum Benson 2006-04-27 15:20:56 UTC
I vote for the patch, provided it only affects keyboard usage.  Having the nodes expand when you *click* is, I agree, quite useful.  But for people who can't use a mouse, the extra keyboarding required to navigate through top level titles is an unnecessary  hassle IMHOO.
Comment 8 Don Scorgie 2006-06-11 09:23:17 UTC
Patch has been committed to CVS HEAD.  Closing.

2006-06-11  Don Scorgie  <dscorgie@cvs.gnome.org>

	* src/yelp-window.c: 
	Don't auto-expand sections in left pane (bug #167070)