After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 167010 - D'n'D icon handling slightly broken
D'n'D icon handling slightly broken
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-11 00:03 UTC by Christian Neumair
Modified: 2005-09-18 07:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Proposed patch (1.01 KB, patch)
2005-02-11 00:06 UTC, Christian Neumair 		none Details | Review
Proposed patch #2 (2.39 KB, patch)
2005-02-11 00:45 UTC, Christian Neumair 		none Details | Review
Proposed patch #3, slight addition to patch #1 (665 bytes, patch)
2005-02-11 00:48 UTC, Christian Neumair 		none Details | Review

Description Christian Neumair 2005-02-11 00:03:14 UTC 
Please describe the problem:
Currently, D'n'D pixbufs are only assigned to launchers, and if the button
pixbuf changes, they might not be notified and still use the old pixbuf.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Christian Neumair 2005-02-11 00:06:18 UTC 
Created attachment 37320 [details] [review]
Proposed patch

After applying the patch, the D'n'D pixbuf will be set correctly for all
PanelButton-derived widgets (i.a. launchers and action buttons) on the fly,
i.e. when the actual drag takes place.
Comment 2 Christian Neumair 2005-02-11 00:45:59 UTC 
Created attachment 37325 [details] [review]
Proposed patch #2

After applying this patch, all menu item drag icons should be set correctly as
well.
Comment 3 Christian Neumair 2005-02-11 00:48:50 UTC 
Created attachment 37326 [details] [review]
Proposed patch #3, slight addition to patch #1

This was actually supposed to go into the first patch. Oh well, I'm getting old
;).
Comment 4 Vincent Untz 2005-02-26 19:30:30 UTC 
Christian: I'm really not sure about this and I'm pretty reluctant to change
code now...

I'd really prefer if bug #116577 could be fixed. This is the real way to fix the
bug.
Comment 5 Christian Neumair 2005-02-26 21:55:49 UTC 
Maybe I don't see the point but what is the direct link to this bug? In what way
is my patch wrong? Doesn't the icon name mean that one can specify an icon name
that is looked up against the theme? Do all PanelButton-derived widgets register
and set icons through the theme?!
Comment 6 Vincent Untz 2005-09-18 07:28:51 UTC 
At last fixed in HEAD.