GNOME Bugzilla – Bug 167002
Clone source in wrong place when cloning from one picture to another.
Last modified: 2008-01-15 12:47:39 UTC
Distribution/Version: Current Had this problem also in the past. When I use the clone tool and clone from one picture to another it shows the source in the wrong location, normally within the destination picture. It still moves with the mouse? I have not changed my screen resolution and it is common to all machines I use GIMP on.
Created attachment 37470 [details] [review] patch for app/tools/gimpclonetool.[ch] from cvs HEAD The attached patch solves the problem for me. It works by remembering the gdisp in the button-press callback, and setting the draw tool's gdisp to the remembered gdisp when drawing the source marker.
You should declare the pointer to src display as a weak pointer so that it is nullified if the display goes away. I wonder when this feature got lost. I think it used to work at some point in time...
Created attachment 37473 [details] [review] revised patch for app/tools/gimpclonetool.[ch] Revised to make it a weak pointer as requested. I tested by closing the view on which the clone source is set, and there are no error messages -- although of course the source marker goes away.
Looks correct to me, but I'd like to have Mitch comment on this change before it goes into the stable tree.
Patch looks fine. Please commit to both branches.
Okay, fixed in both branches. 2005-02-16 Bill Skaggs <weskaggs@primate.ucdavis.edu> * app/tools/gimpclonetool.[ch]: make sure clone source is shown in correct display, fixes bug #167002.