After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166932 - Show output file type in prefs
Show output file type in prefs
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: interface
2.9.x
Other Linux
: Normal enhancement
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
: 167514 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-02-10 14:29 UTC by Ross Burton
Modified: 2005-02-16 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch against CVS HEAD (3.51 KB, patch)
2005-02-14 12:45 UTC, Madhan Raj M
none Details | Review
Patch against CVS HEAD (3.51 KB, patch)
2005-02-14 12:46 UTC, Madhan Raj M
rejected Details | Review
Screen shot (244.46 KB, image/png)
2005-02-14 13:13 UTC, Madhan Raj M
  Details
Updated Patch (3.88 KB, patch)
2005-02-14 17:46 UTC, Madhan Raj M
needs-work Details | Review
Updated Screen Shot (103.53 KB, image/png)
2005-02-15 05:22 UTC, Madhan Raj M
  Details

Description Ross Burton 2005-02-10 14:29:19 UTC
People will want to know what format a profile writes to, so maybe the prefs
dialog should take the current profile, find the encoder element, take the mime
type from it's src pad and display the human readable form in the UI.

Even better add this to the combo...
Comment 1 Lars Strojny 2005-02-10 14:30:31 UTC
Really a good idea! :)
Comment 2 Madhan Raj M 2005-02-14 12:45:00 UTC
Created attachment 37454 [details] [review]
Patch against CVS HEAD
Comment 3 Madhan Raj M 2005-02-14 12:46:03 UTC
Created attachment 37455 [details] [review]
Patch against CVS HEAD
Comment 4 Madhan Raj M 2005-02-14 13:13:13 UTC
Created attachment 37456 [details]
Screen shot
Comment 5 Ross Burton 2005-02-14 13:23:31 UTC
Comment on attachment 37455 [details] [review]
Patch against CVS HEAD

It would be better to show the human-readable description of the MIME type, as
I discussed in the bug.
Comment 6 Madhan Raj M 2005-02-14 17:46:25 UTC
Created attachment 37462 [details] [review]
Updated Patch
Comment 7 Madhan Raj M 2005-02-15 05:22:20 UTC
Created attachment 37482 [details]
Updated Screen Shot
Comment 8 Ross Burton 2005-02-15 20:28:32 UTC
*** Bug 167514 has been marked as a duplicate of this bug. ***
Comment 9 Ross Burton 2005-02-16 13:16:05 UTC
Comment on attachment 37462 [details] [review]
Updated Patch

You've removed the use of the gnome-media chooser widget but other pieces of
code still use gm_audio_profile_* functions.
Comment 10 Ross Burton 2005-02-16 13:21:38 UTC
To avoid duplication don't work on this any more, I'm taking the MIME parts from
your patch and merging them into a copy of the widget.
Comment 11 Ross Burton 2005-02-16 15:09:48 UTC
Refactored version in CVS, thanks.