GNOME Bugzilla – Bug 166826
raise parent window together with transient dialogs
Last modified: 2005-02-12 07:53:23 UTC
(uhm... dunno if the summary makes sense, but I could not come up with anything better) This is a spinoff of bug http://bugzilla.gnome.org/show_bug.cgi?id=157360 I verified that downgrading to metacity 2.9.1 fixes the problem I am reporting now (but obviously reopens the problem discussed in 157360). Even if downgrading metacity brings back the expected behavior, I'm filing this against libwnck as requested by Elijah. Steps to reproduce: - Open gedit (fullscreen for that matters) - Open devhelp (fullscreen for that matters) - press ctrl+f in gedit to get a Search dialog - without closing the search dialog switch to devhelp using the window list - switch back to gedit using the window list (note that in the window list you get just two buttons one for gedit and the other for devhelp: the search dialog doesn't have a separate button in the window list) Results: you get the Search dialog focused with devhelp behind it Expected results (what happens with metacity 2.9.1) you get the Search dialog focused with gedit's main window behind it. [Note that it is not specific to gedit search dialog, using a specific example to make things clearer (as discussed in 157360, the problem with metacity 2.9.1 is that once you dismiss the dialog devhelp gets focused instead of gedit)
Corollary to Murphy's Law: If you emphasize something strongly enough, you will be wrong. Example: This bug. Okay, so I wasn't totally wrong in having you file this against libwnck. The problem is that libwnck was attempting to play the role of the window manager, in an effort to cover up a bug in Metacity (namely, bug 166894; though libwnck was only covering up part of that bug). Unfortunately, what libwnck tried to do was (1) an ugly hack, and (2) was not robust. The correct solution was to make Metacity behave correctly (which is robust and also fixes other problems). However, the hack still needs to be ripped out of libwnck. I'll attach a patch in a minute that I'm committing, which rips the hack out of libwnck.
Created attachment 37385 [details] [review] remove the hack
(Oh, and the reason Metacity 2.9.13 stopped working with the ugly hack that libwnck was doing was because we started ignoring xconfigurerequests since they were often causing problems; see bug 166395)