GNOME Bugzilla – Bug 166678
Alternative button order
Last modified: 2008-01-15 12:47:27 UTC
As a KDE user, I'm used to the following button order on dialogs : OK, Apply, Cancel. In the Gnome HIG, the order is different and I always find it unintuitive (for me, a KDE user) to use the Gimp dialogs. Gimp should use the documented GTK function for displaying an alternative button order on the dialogs.
Created attachment 37173 [details] [review] Alternative button order for GIMP This is a patch, covering all GIMP dialogs I could find, from Open, Save, etc. to Filters and Script-Fu.
Thanks for your bug report and patch. This issue has been discussed previously, and a decision was made to align with the GNOME HIG. We will definitely not unconditionally change button order. Perhaps if you can come up with a way to do this only if the user is running KDE then this has slightly less chance of getting rejected. I can't promise anything though.
The button order is altered only if the setting : gtk-alternative-button-order = 1 is present in the user's .gtkrc-2.0, otherwise, the button order remains unchanged.
Dave, is it really neccessary to make this conditional? I thought the purpose of the switchable order was to adjust this based on a gloabl setting - which would be set by KDE, GNOME or the user himself to the look he wants.
This has been discussed before and we publically announced that we would accept such a patch. We even asked the GTK+ people to provide this setting. Reopening the bug report and setting milestone to 2.4. We should get this patch into CVS as soon as possible. It does however appear that it is against the stable branch. Patrice, could you merge this into CVS HEAD?
See also bug #74669.
Created attachment 37184 [details] [review] Updated patch against CVS HEAD The patch applied surprisingly good against HEAD. Only two hunks failed which I've fixed manually. Here's an updated patch. Will apply as soon as we depend on GTK+ 2.6.
I admit I didn't understand the idea of the switchable button order. Excuse me, Patrice.
No problems :) Now, I'll double check to see if I missed some dialogs... Thank you very much for your collaboration!
Comment on attachment 37184 [details] [review] Updated patch against CVS HEAD You missed a couple of message dialogs (grep for gimp_message_dialog_new). Please submit another patch for these. Also, next time, please try to be more careful as to properly indent your code. I think I fixed most of the indentation problems in the core... 2005-02-08 Sven Neumann <sven@gimp.org> Applied a patch from Patrice Tremblay that makes (almost) all dialogs obey the "gtk-alternative-button-order" setting (bug #166678). Changes too many files to list them all...
*** Bug 156376 has been marked as a duplicate of this bug. ***
Patrice, you also missed one or more GimpViewableDialogs. Better grep for gimp_viewable_dialog_new() and gimp_tool_dialog_new() as well.
After another check, Ive found many dialogs not converted... Look for a new patch (against CVS head) tomorrow.
Created attachment 37275 [details] [review] Alternative button order PART 2 (against CVS head) 22 new not converted dialogs found. Please Gimpers everywhere, check if I missed some, and tell me.
Applied to HEAD. Thanks again for the patches. I am closing this report as FIXED now. If there should turn up more dialogs that need to be converted, please reopen the report.
Created attachment 37287 [details] [review] Small compile fix This is a small compile fix for gimpdisplayshell-close.c. (note to self: always compile before sending patch) This is now mostly complete except for the transform tools, I cant find where to switch the cancel and the "action" button (eg. Cancel / Rotate). Have a nice day!
Thanks for pointing to the transform tools. Will care about them.
Done: 2005-02-10 Michael Natterer <mitch@gimp.org> * app/tools/gimpcroptool.c * app/tools/gimptransformtool.c: alternative button order for the info dialogs (bug #166678).
Created attachment 37629 [details] [review] One more dialog converted Forgot a dialog in gimp export (when saving an image with multiple layers)...
Thanks. Applied to HEAD: 2005-02-18 Michael Natterer <mitch@gimp.org> * libgimp/gimpexport.c (export_dialog): applied patch from Patrice Tremblay which sets an alternative button order for the export dialog (bug #166678).