After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 166239 - Shortcuts to network sites do not work in 'Places' menu
Shortcuts to network sites do not work in 'Places' menu
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
git master
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-04 06:57 UTC by Dennis Cranston
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.34 KB, patch)
2005-02-04 07:34 UTC, Dennis Cranston 		needs-work Details | Review
Proposed patch. (1.37 KB, patch)
2005-02-04 16:47 UTC, Dennis Cranston 		none Details | Review

Description Dennis Cranston 2005-02-04 06:57:45 UTC 
In the file selector, I added a shortcut to shared folder on a Windows computer
on my local network.  The path of the shortcut is smb://elevation/SharedDocs.

A 'SharedDocs' menu item was automatically added to the 'Places' menu on the
panel.  But, when I select the menu item the folder is not opened.  Instead, an
error dialog displays, "Cannot display location 'file:///SharedDocs'  Details: 
There is not default action associated with this location."
Comment 1 Dennis Cranston 2005-02-04 07:02:44 UTC 
I dragged the 'SharedDocs' menu item to the panel and displayed the new
launcher's properties.  The problem is that the URL value is set to
"/SharedDocs".  If I change it to "smb://elevation/SharedDocs" then the launcher
will work correctly.
Comment 2 Vincent Untz 2005-02-04 07:27:18 UTC 
Will look at this
Comment 3 Dennis Cranston 2005-02-04 07:34:49 UTC 
Created attachment 36963 [details] [review]
Proposed patch.

This patch fixes the problem for me.
Comment 4 Vincent Untz 2005-02-04 08:04:31 UTC 
Comment on attachment 36963 [details] [review]
Proposed patch.

Thanks for the patch. Some comments:

  + I think it's better to always use gnome_vfs_uri_to_string() even if it's a
local URI

  + you'll need to free full_uri in this case (it's not a const char *)

  + does it work with URI that have spaces or special letters like "é" in the
path?
Comment 5 Dennis Cranston 2005-02-04 16:47:29 UTC 
Created attachment 36995 [details] [review]
Proposed patch.

This patch makes the modifications listed in the previous comment. 

I created a local folder named "à é" and added it to my bookmarks.  The
corresponding 'Places' menu item worked.
Comment 6 Dennis Cranston 2005-02-04 16:50:32 UTC 
You probably want to change the line from:
   const char *full_uri;
to:
   char *full_uri;
Comment 7 Vincent Untz 2005-02-04 20:05:57 UTC 
Thanks, I committed this.
Comment 8 Sergej Kotliar 2005-06-02 16:12:46 UTC 
Hi!

I'm using Fedora Core 4test3, and I'm still getting this error. Would you mind
telling me what gnome-panel version the fix went into?

I am using the following version:

gnome-panel-2.10.1-10
Comment 9 Dennis Cranston 2005-06-02 21:06:38 UTC 
The patch was applied to 2.9.91.