After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165979 - Window Selector initial background is not correct
Window Selector initial background is not correct
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: window selector
git master
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-02-01 21:59 UTC by Vincent Untz
Modified: 2015-03-24 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch with obviously broken indentation (960 bytes, patch)
2005-02-01 23:01 UTC, Vincent Noel 		none Details | Review

Description Vincent Untz 2005-02-01 21:59:05 UTC 
Add a window selector to a panel.
Make this panel very large. Make it transparent.
Restart the panel.
Look at the window selector background and wonder what broke ;-)

Vincent: you're my personal window selector hero, so I'm cc'ing you.
Comment 1 Vincent Noel 2005-02-01 23:01:59 UTC 
Created attachment 36849 [details] [review]
patch with obviously broken indentation

Here is a patch that fixes the bug.

The patch is not as clever as I'd liked, but it works.
What happens here is that the WnckSelector requests a small size, then asks for
the background pixmap, then resizes itself. The pixmap is too small for the new
size.

In panel-menu-bar.c, this case is handled by using the panel_background_*
functions. I don't think these functions are supposed to be used in regular
applets though...
Comment 2 Vincent Untz 2005-02-02 08:46:35 UTC 
This wasn't working very nice with some sizes (since the size we have in fill()
is not the real one). So I fixed it by updating the background in _allocate().

> In panel-menu-bar.c, this case is handled by using the panel_background_*
> functions. I don't think these functions are supposed to be used in regular
> applets though...

panel_background_* is not in libpanel-applet. And the panel menu bar uses this
because it has no access to libpanel-applet.
Comment 3 Vincent Noel 2005-02-02 13:23:44 UTC 
I was not aware of the panbel_applet_get_background function. This is indeed much better :-)
thanks !