Created attachment 36525 [details] [review]
The patch to use the same alert appearance and text for empty trash action

This breaks UI freeze. Although does look vaguely correct.

I would personally avoid using any eel functions that we weren't already using
(unless there is a really good reason I haven't thought of).

Request permission with the release-team to break the UI freeze (please CC me)
and we can then proceed.

Tentatively marking G10, however if the release-team deny it, it'll obviously be
bounced back to G12.

The eel stuff come from a 'blind' cut-and-paste from nautilus code. Sorry.


I'll provide the right patch shortly.

Created attachment 36591 [details] [review]
The same patch, but without eel_* stuff

Please note that this patch silently change "translator_credits" to
"translator-credits"

I noticed the translator-credits change, it is correct and consist with other
changes we've been making.

This can be committed pending approval from the release team. Thanks.

Titles do not belong on alert dialogs.  You shouldn't remove this line;
otherwise, the title will be "Warning".  

-	gtk_window_set_title (GTK_WINDOW (dialog), "");

You have release team approval.

2005-02-07  Davyd Madeley  <davyd@madeley.id.au>

        * src/trashapplet.c: Sync Empty Trash dialog with Nautilus. Closes
          #165241. Patch from Luca Ferretti <elle.uca@libero.it>.