After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 165012 - Please use automatic line wrapping in GtkAboutDialog license window
Please use automatic line wrapping in GtkAboutDialog license window
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.6.x
Other All
: Normal normal
: Small API
Assigned To: gtk-bugs
Nautilus Maintainers
Depends on:
Blocks: 309460
 
 
Reported: 2005-01-23 20:02 UTC by Christian Rose
Modified: 2005-07-05 15:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
implement wrap-license-text property (3.67 KB, patch)
2005-07-05 00:00 UTC, Christian Persch
none Details | Review

Description Christian Rose 2005-01-23 20:02:55 UTC
#: src/nautilus-window-menus.c:407
msgid ""
"Nautilus is free software; you can redistribute it and/or modify \n"
"it under the terms of the GNU General Public License as published by \n"
"the Free Software Foundation; either version 2 of the License, or \n"
"(at your option) any later version."

#: src/nautilus-window-menus.c:411
msgid ""
"Nautilus is distributed in the hope that it will be useful, \n"
"but WITHOUT ANY WARRANTY; without even the implied warranty of \n"
"MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the \n"
"GNU General Public License for more details."

#: src/nautilus-window-menus.c:415
msgid ""
"You should have received a copy of the GNU General Public License \n"
"along with Nautilus; if not, write to the Free Software Foundation, Inc., \n"
"59 Temple Place, Suite 330, Boston, MA  02111-1307  USA"

If you have the possibility, please use automatic linewrapping here where
possible, instead of hardcoding newlines (\n) in the sentences. It may be very
difficult for a translator to guess where he or she should put her newlines.

Furthermore, hardcoding newlines makes it more problematic if you use a
different or bigger font, which may be needed for accessibility reasons, whereas
automated linewrapping solves that problem as well.

http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#line-breaks
Comment 2 Alexander Larsson 2005-01-25 09:16:57 UTC
GtkAboutDialog doesn't auto-wrap the license field, so we can't do this right now.
Comment 3 Matthias Clasen 2005-01-25 18:36:00 UTC
Discussed this with Owen a bit, and we don't think we can compatibly change the
wrapping behaviour without introducing new api. One thing we can an will do 
is to make sure that the license dialog comes up wide enough to not have a
horizontal scrollbar.

The problem with turning on wrapping now is that you will end up with
a mixture of short and long lines. 

A possible api addition to allow wrapping would be to add an extra
property like "wrap-license-text" defaulting to FALSE.
Comment 4 Matthias Clasen 2005-01-26 06:18:13 UTC
2005-01-26  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkaboutdialog.c (display_license_dialog): Make sure
	the license dialog is initially displayed without a horizontal
	scrollbar.  
	(gtk_about_dialog_class_init): Document the fact that the 
	license text is not wrapped.  (#165012, Christian Rose)


Leaving this open to consider adding api for unformatted license text
Comment 5 Christian Persch 2005-07-05 00:00:05 UTC
Created attachment 48654 [details] [review]
implement wrap-license-text property
Comment 6 Matthias Clasen 2005-07-05 14:53:56 UTC
2005-07-05  Matthias Clasen  <mclasen@redhat.com>

        * gtk/gtk.symbols:
        * gtk/gtkaboutdialog.[hc]: Add a wrap-license property
        with getter and setter.  (#165012, Christian Rose,
        based on a patch by Christian Persch)

Comment 7 Martin Kretzschmar 2005-07-05 15:37:45 UTC
You kept the Since: 2.6 marker near g_object_class_install_property. Should be 2.8.