After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164938 - Patch to add new and deprecate old filter methods of Gdk::Window
Patch to add new and deprecate old filter methods of Gdk::Window
Status: RESOLVED WONTFIX
Product: gtkmm
Classification: Bindings
Component: general
2.5
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2005-01-22 21:01 UTC by Bryan Forbes
Modified: 2005-02-01 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdk_window.diff (3.32 KB, patch)
2005-01-22 21:02 UTC, Bryan Forbes 		none Details | Review

Description Bryan Forbes 2005-01-22 21:01:46 UTC 
I have added add_filter and remove_filter which take slots to Gdk::Window.  I
have tested this code in "Coaster" for use with a tray icon on the panel, but
the code is so strange that I thought it might be a bit much for the gtkmm
examples.  If need be, I can add an example.
Comment 1 Bryan Forbes 2005-01-22 21:02:18 UTC 
Created attachment 36388 [details] [review]
gdk_window.diff
Comment 2 Murray Cumming 2005-01-23 19:39:15 UTC 
1. I'm not happy that the SignalProxy_FilterFunc that's newed in add_filter() is
never deleted. At first glance, it looks like the C function needs a
destroy_notify callback.
2. In remove_filter(), gdk_window_remove_filter() is almost certainly expecting
the same function-pointer and user-data that was previously given to
gdk_window_add_filter. I don't see the sense in newing another
SignalProxy_FilterFunc filter.
Comment 3 Murray Cumming 2005-02-01 17:44:34 UTC 
I see no great need for this, and it's marked as something that we shouldn't use
much, and there's no easy way to wrap it.