After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164856 - [PATCH] GSM encoding/decoding improvements
[PATCH] GSM encoding/decoding improvements
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other All
: High normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-21 21:00 UTC by Jeffrey C. Ollie
Modified: 2005-06-30 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to GSM encoder/decoder. (17.67 KB, patch)
2005-01-21 21:01 UTC, Jeffrey C. Ollie 		needs-work Details | Review
New patch (16.42 KB, patch)
2005-01-24 16:33 UTC, Jeffrey C. Ollie 		committed Details | Review

Description Jeffrey C. Ollie 2005-01-21 21:00:19 UTC 
Changes:

1) Modified the encoder and decoder to only accept an 8Khz sample rate.  GSM (by
definition) is limited to a 8Khz sample rate.  The GSM encoder/decoder plugins
were allowing sample rates from 1Khz to 48Khz.  Since GSM files/streams do not
contain any metadata on what rate to decode at you either had to manually
specify the sample rate or you would get odd results.

2) Modified the decoder to produce timestamps/offsets in the buffers that it
generates.

3) Modified encoder/decoder to handle discontinuity & EOS events.
Comment 1 Jeffrey C. Ollie 2005-01-21 21:01:05 UTC 
Created attachment 36351 [details] [review]
Patch to GSM encoder/decoder.
Comment 2 Maciej Katafiasz 2005-01-24 10:58:05 UTC 
Reviewed the patch. Seems to work as per very basic testing I gave it. Code
looks OK, but I have 2 slight issues:
1) why are you sending DISCONT in first run of chain() after element is created?
I don't see much sense here, there's no stream to DISCONT yet as it is very
first run after creation
2) Please s/#ifdef __cplusplus/G_BEGIN_DECLS/

Marking as needwork, but the above are very minor issues, will commit after they
are resolved.
Comment 3 Jeffrey C. Ollie 2005-01-24 16:33:01 UTC 
Created attachment 36471 [details] [review]
New patch
Comment 4 Jeffrey C. Ollie 2005-01-24 16:34:12 UTC 
Uploaded new patch with suggested changes.
Comment 5 Maciej Katafiasz 2005-01-24 21:58:14 UTC 
Comment on attachment 36471 [details] [review]
New patch

Almost there, you don't get to put ; after G_BEGIN_DECLS ;). Fixed and
commited, thanks.