GNOME Bugzilla – Bug 164856
[PATCH] GSM encoding/decoding improvements
Last modified: 2005-06-30 15:48:50 UTC
Changes: 1) Modified the encoder and decoder to only accept an 8Khz sample rate. GSM (by definition) is limited to a 8Khz sample rate. The GSM encoder/decoder plugins were allowing sample rates from 1Khz to 48Khz. Since GSM files/streams do not contain any metadata on what rate to decode at you either had to manually specify the sample rate or you would get odd results. 2) Modified the decoder to produce timestamps/offsets in the buffers that it generates. 3) Modified encoder/decoder to handle discontinuity & EOS events.
Created attachment 36351 [details] [review] Patch to GSM encoder/decoder.
Reviewed the patch. Seems to work as per very basic testing I gave it. Code looks OK, but I have 2 slight issues: 1) why are you sending DISCONT in first run of chain() after element is created? I don't see much sense here, there's no stream to DISCONT yet as it is very first run after creation 2) Please s/#ifdef __cplusplus/G_BEGIN_DECLS/ Marking as needwork, but the above are very minor issues, will commit after they are resolved.
Created attachment 36471 [details] [review] New patch
Uploaded new patch with suggested changes.
Comment on attachment 36471 [details] [review] New patch Almost there, you don't get to put ; after G_BEGIN_DECLS ;). Fixed and commited, thanks.