GNOME Bugzilla – Bug 164826
[patch] Avidemux doesn't handle seek on audiopads
Last modified: 2005-01-27 10:06:23 UTC
avidemux doesn't handle seek on audiopads. I've uncommented the few lines of code that prevented avidemux for handling them and corrected gstmad.c so it forwards the seek event and allows seek for non-vbr mp3 streams.
Created attachment 36334 [details] [review] GstAVIDemux : Enables seek on audio pads
Created attachment 36335 [details] [review] GstMad : forward seek event patch This patch forwards the seek event upstream. If the seek isn't handled or returns FALSE, gst_mad_src_event will return FALSE.
Created attachment 36378 [details] [review] GstMad : Patch that forwards seek events upstream This patch is a bit cleaner (removed unused normal_seek and index_seek)
Bumping prio as it's a patch. Unfortunately can't test if it works, as mp3 dies horrible death when seeking on my box, no clue why and don't have time to troubleshoot it atm.
Comment on attachment 36334 [details] [review] GstAVIDemux : Enables seek on audio pads Simple, good.
Comment on attachment 36378 [details] [review] GstMad : Patch that forwards seek events upstream The mad patch is wrong. You shouldn't *only* forward seek events, that breaks seeking in mp3 files. You should forward and, if that fails (e.g. for mp3 files), you should use the conventional seeking methods.
Created attachment 36503 [details] [review] GstMad : forward seek event patch v2 This patch forwards the seek upstream, and if that fails try with mad's normal_seek or index_seek.
That looks good, so applied.