After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164359 - recently-used breaks gedit
recently-used breaks gedit
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: recent-files
unspecified
Other All
: High critical
: ---
Assigned To: Emmanuele Bassi (:ebassi)
gedit QA volunteers
: 168129 303272 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-01-17 15:16 UTC by Alexandre Gomes
Modified: 2005-07-21 22:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
the breaker file (38.97 KB, application/octet-stream)
2005-01-17 15:17 UTC, Alexandre Gomes 		  Details
minimal patch (639 bytes, patch)
2005-01-23 15:13 UTC, Paolo Borelli 		none Details | Review
A slightly different stack trace (5.74 KB, text/plain)
2005-02-11 21:51 UTC, Arthur Peters 		  Details
an updated version of the patch against CVS HEAD (601 bytes, patch)
2005-07-20 02:34 UTC, Brent Smith (smitten) 		none Details | Review

Description Alexandre Gomes 2005-01-17 15:16:17 UTC 
Steps to reproduce:
1. Start gedit with file attached in home dir
 


Stack trace:
Program received signal SIGSEGV, Segmentation fault.

+ Trace 54603

Thread NaN (LWP 4464)

  • #0 g_utf8_validate
    from /usr/lib/libglib-2.0.so.0
  • #1 g_convert_with_fallback
    from /usr/lib/libglib-2.0.so.0
  • #2 g_filename_to_utf8
    from /usr/lib/libglib-2.0.so.0
  • #3 egg_recent_item_get_short_name
  • #4 egg_recent_view_bonobo_new
  • #5 egg_recent_view_bonobo_new
  • #6 g_cclosure_marshal_VOID__POINTER
    from /usr/lib/libgobject-2.0.so.0
  • #7 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #8 g_signal_has_handler_pending
    from /usr/lib/libgobject-2.0.so.0
  • #9 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #10 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #11 egg_recent_model_changed
  • #12 egg_recent_view_gtk_get_type
  • #13 egg_recent_view_set_model
  • #14 gedit_mdi_get_output_window_from_window
  • #15 g_cclosure_marshal_VOID__OBJECT
    from /usr/lib/libgobject-2.0.so.0
  • #16 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #17 g_signal_has_handler_pending
    from /usr/lib/libgobject-2.0.so.0
  • #18 g_signal_emit_valist
    from /usr/lib/libgobject-2.0.so.0
  • #19 g_signal_emit
    from /usr/lib/libgobject-2.0.so.0
  • #20 bonobo_mdi_get_window_info
  • #21 bonobo_mdi_get_window_info
  • #22 bonobo_mdi_open_toplevel
  • #23 main 


Other information:
Comment 1 Alexandre Gomes 2005-01-17 15:17:23 UTC 
Created attachment 36135 [details]
the breaker file

This is the file causing the prob
Comment 2 Khasim Shaheed 2005-01-18 13:21:51 UTC 
Did you mean that run gedit in terminal using the attached file as input?
If that is the case i am able to open it without any problem.

The version of Gnome i am using is 2.9.3 and the gedit version is 2.9.3.
Comment 3 Khasim Shaheed 2005-01-18 13:22:43 UTC 
Can you please try with the latest version.
Comment 4 Paolo Borelli 2005-01-18 13:54:04 UTC 
Nope, the reporter means that that the file he has attached is his
~/.recently-used file.


Khasim, by the way, I noticed that you're cc'ing yourself to a lot of gedit
bugs: note that if you want you can just add gedit-qa-maint@bugzilla.gnome.org
to your watch-list in the bugzilla preferences instead of manually adding
yoursef to each bugreport.
Comment 5 Paolo Borelli 2005-01-23 15:13:01 UTC 
Created attachment 36414 [details] [review]
minimal patch

Here is the minimal patch which at least fixes the segfault.


I already applied it to the gedit copy of recent-files, reassigning to libegg
and upping priority
Comment 6 Kjartan Maraas 2005-01-25 18:16:59 UTC 
Does this look ok to commit as well?
Comment 7 Vincent Untz 2005-01-28 22:27:33 UTC 
Paolo: I committed the fix to gnome-vfs, so this patch is no longer necessary.
However, it's safe to apply it so I'm note sure if we should close the bug.
Comment 8 Paolo Borelli 2005-01-29 09:05:34 UTC 
IHMO we should add a

g_return_val_if_fail (short_name != NULL, NULL)


so that we do not crash if the problem turns up again in the future, or if the
user runs a strange combination of vfs and recent-files versions
Comment 9 Kjartan Maraas 2005-01-30 18:48:13 UTC 
Moving this onto the 2.10 milestone. Should be an easy fix too.
Comment 10 Arthur Peters 2005-02-11 21:51:11 UTC 
Created attachment 37374 [details]
A slightly different stack trace

I am expereincing this problem with a slightly different stack trace. So this
probably not useful info, but it might help so here it is.

With the following in .recently-used:
<RecentItem>
<URI>http://www.vistaprint.com/vp/ssrview.aspx?doc_id=33644048&amp;Page=Front&amp;dtm=2%2F11%2F2005+11%3A20%3A38+AM</URI>

    <Mime-Type>image/jpeg</Mime-Type>
    <Timestamp>1108151578</Timestamp>
    <Groups>
      <Group>Eye of Gnome</Group>
    </Groups>
  </RecentItem>

I get the attached crash in gnome-panel. I got a very similar one in eog.
Comment 11 Luis Villa 2005-02-28 15:11:55 UTC 
vincent: when you say in comment 7 that you've fixed VFS, that would prevent the
crash for all apps, right? If I'm reading you write, this is not a showstopper,
then?
Comment 12 Vincent Untz 2005-02-28 15:15:40 UTC 
That's right, that's not a showstopper anymore (although it'd be nice to have
the patch committed)
Comment 13 Brent Smith (smitten) 2005-07-20 02:34:04 UTC 
Created attachment 49436 [details] [review]
an updated version of the patch against CVS HEAD

here's an updated patch in hopes that this can get committed...
Comment 14 Brent Smith (smitten) 2005-07-20 02:42:51 UTC 
*** Bug 168129 has been marked as a duplicate of this bug. ***
Comment 15 Emmanuele Bassi (:ebassi) 2005-07-20 07:31:30 UTC 
brent, libegg/recent-files HEAD already fixes this issue.
Comment 16 Vincent Untz 2005-07-20 14:53:57 UTC 
Emmanuele: does it mean we can close this bug?
Comment 17 Emmanuele Bassi (:ebassi) 2005-07-21 08:11:48 UTC 
as far as I'm concerned (recent-files code), I'd say we can close it.
Comment 18 Vincent Untz 2005-07-21 09:00:54 UTC 
Marking as FIXED, then :-)
Comment 19 Brent Smith (smitten) 2005-07-21 22:14:25 UTC 
*** Bug 303272 has been marked as a duplicate of this bug. ***