GNOME Bugzilla – Bug 164244
disable libgnomesu support
Last modified: 2011-11-11 10:03:55 UTC
libgnomesu support could be disabled (though i'd like default to be --enable-libgnomesu). TODO: - configure.in : enable/disable libgnomesu - src/procdialogs.c (procdialog_create_root_password_dialog): Add dialog if libgnomesu is disabled. "You can't kill/renice this process because procman has not be built with libgnomesu support" doesn't sound user-friendly, what would be the error message ?
Please disable it by default if libgnomesu is not installed. Right now procman breaks my jhbuild... Maybe we could avoid the dialog at all by making the menu insensitive, but that's not very user friendly either. If we have a message I think it should be something like "You can't kill/renice this process because it's owned by another user".
Btw as a compromise for the disagreements... What about enabling libgnomesu support by default if the library is installed but not distribute it with GNOME? That way distributions can deal with the issue... I dont really know the details here, so forgive me if I'm showing my ignorance ;)
That's why i'm looking for someone who knows autotools for TODO#1. For insensitive menu : i don't like the idea to hack everything just because libgnomesu is not installed. I'd rather print an error dialog when renice/kill fails.
Should be fixed.
Created attachment 37179 [details] [review] Patch to implement the feature. Here's a patch which makes procman detect libgnomesu at runtime, using GModule. This patch is not tested because I'm unable to compile procman; I'm stuck with GNOME 2.4. :( But it should give you an idea about what I'm doing.
very nice, i didn't know glib has a dlopen wrapper