After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164125 - spurious selection of RTL text entry when XKB disabled
spurious selection of RTL text entry when XKB disabled
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.6.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 166123 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-01-15 00:15 UTC by Phil Blundell
Modified: 2005-02-04 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
completely fixes regression (535 bytes, patch)
2005-02-04 10:29 UTC, Frederic Crozat 		none Details | Review

Description Phil Blundell 2005-01-15 00:15:16 UTC 
Please describe the problem:
If GDK is compiled with --disable-xkb, gdk_keymap_get_direction() becomes a stub
function that always returns PANGO_DIRECTION_NEUTRAL.  Unfortunately, this
interacts badly with code in GtkTextView that does:

     if (gdk_keymap_get_direction (keymap) != PANGO_DIRECTION_LTR)
	new_keyboard_dir = GTK_TEXT_DIR_LTR;
      else
	new_keyboard_dir  = GTK_TEXT_DIR_RTL;

The result is that a GtkTextView with no contents, or one that is displaying
only digits, will adopt RTL mode.  If you enter some text, it switches back to
LTR mode.

GtkEntry seems to have a similar problem.


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Owen Taylor 2005-02-03 03:54:59 UTC 
*** Bug 166123 has been marked as a duplicate of this bug. ***
Comment 2 Frederic Crozat 2005-02-04 10:28:47 UTC 
Reopening : fix in CVS isn't complete when focus is not in the widget.

Attached patch fixes the remaining regression.
Comment 3 Frederic Crozat 2005-02-04 10:29:23 UTC 
Created attachment 36971 [details] [review]
completely fixes regression
Comment 4 Matthias Clasen 2005-02-04 15:37:58 UTC 
2005-02-04  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkentry.c (gtk_entry_create_layout): Avoid spurious
	selection of RTL direction if the widget does not have 
	focus.  (#164125, Frederic Crozat)