GNOME Bugzilla – Bug 164090
Keyboard Layout Options UI sucks
Last modified: 2005-01-19 23:18:56 UTC
-Both treeviews are too narrow to display the full text of options within themselves -It is not clear which available options are mutually exclusive: user must hightlight available options and see if "Add" is available in order to find out -When an option has been moved to "Selected options" it is displayed without its group header, and some of the names are meaningless outside of context.
Created attachment 36021 [details] [review] New UI for keyboard layouts Of course I wouldn't have filed such an inflammatory subject line if I didn't have a better idea :-) The attached patch creates an expander for each group of options, and fills it with check buttons (multiselect groups) or radio buttons (non-multiselect groups). As far as I can tell it works, but I'm sure someone will figure out how to break it. Note that the patch also includes some non-controversial glade changes from Bug 159685, and if accepted should close that bug. As an added bonus, my code is actually shorter than the old version, even including my inline comments.
Created attachment 36022 [details] Screenshot of new keyboard layout UI
Well, the .c file are ok. But glade file was changed in CVS - so the patch does not apply :(
AnonCVS is sufficiently out of date that I can't make a fresh patch right now. I guess all that changed was that you applied Bug 159685? Maybe you could just unapply that and apply this one (which conflicts because it includes the changes from there).
Created attachment 36148 [details] [review] Updated patch This should work against current CVS.
Created attachment 36225 [details] [review] Updated version The highlighting now depends on the chosen options. Also, C++ comments // are replaced with the C ones /**/
Created attachment 36226 [details] The new screenshot - with selective highlighting Updated screenshot. Really looks good.
So, summarrizing. I like the new UI. Today/tomorrow I'll make this new screenshot visible (in planet.gnome.org and in the usability list) - and after GTP approves the string breakage _("Default") - I will commit.
the string freeze is on the 7th of february no need to ask to change something ...
Created attachment 36249 [details] [review] Version with "Layout Options" page only visible if there actually are options to show This is a version of Sergey's latest that has the "Layout Options" tab invisible in the glade file, and only made visible in the code for adding a group of options: this way the tab should only be shown if there actually are options: otherwise we would just have a blank page.
John, how could it happen that there are no options to show?? Never heard of such xorg|xfree|base.xml - without any options...
I noticed this on a remote connection to a FC2 box from the Exceed proprietary X server for windows.
Ghm... And which XML file is used in this case? I though it was same xorg.xml - which contains the options... Do you have XKB enabled at all? Actually, I'd be interested in more details regarding your configuration...
I'm probably not going to be back at that Exceed machine for a while, a few days at least. However, I can also get no options on my (Ubuntu Warty) machine just by using gdmXnestchooser and logging in to the local machine. Same everything, naturally. If you want to leave instructions for analysing the FC2/Exceed setup, I'll do it when I'm next there.
John, you patch things a bit too fast. Let's make it step-by step if you don't mind:) So, I committed my version of the patch (with the sorting fix). Now, if you please could take the version from CVS and attach the patch for optional layout tab - I'd appreciate it. Regarding gdmXnestchooser - AFAIK it does not have XKB, so the xmodmap part of libxklavier should give you a couple of options (if you have the latest gnome-applets). I will look into it...