GNOME Bugzilla – Bug 164049
[dvdec] NTSC framerate defined incorrectly
Last modified: 2005-06-30 15:47:23 UTC
gst-plugins/ext/dv/gstdvdec.c defines NTSC_FRAMERATE to be 29.997. Unless I am mistaken, this number should be 29.97 (there is one too many nines). As an aside, many of these constants aren't DV specific. Isn't there a better, more common place for them to reside?
it's true that the real value is 30000/1001 = 29.97002997 changing it in my local tree now, would commit it later today thanks for spoting this actually, it is defined here : gst-plugins/ext/libfame/gstlibfame.c: "framerate = (double) { 23.976024, 24.0, 25.0, 29.970030, 30.0, " gst-plugins/ext/dv/gstdvdec.c:#define NTSC_FRAMERATE 29.997 gst-plugins/gst/y4m/gsty4mencode.c: 29.970, 30.000, /* NTSC */ other numbers that are rounded differently : 23.976023999999999 = i don't know (25000/10001 gives 24,975024975) 59.940060000000003 = NTSC * 2 = 60000/1001
fixed in gstreamer (core) and gst-plugins the 23.97... thing is actuall 24000/1001 (it seems some video are around 24 fps instead of usual 25/30 for PAL/NTSC) closing, thanks (and don't hesitate to reopen if i forgot to change some)
It is not around 24. 24/1.001 is exact FILM framerate, which is used for NTSC pull-down content.