After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164037 - Move "Play/pause" button to the left
Move "Play/pause" button to the left
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other All
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2005-01-14 03:54 UTC by Jorn Baayen
Modified: 2015-11-14 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Switch play and previous button (1.08 KB, patch)
2007-01-12 23:12 UTC, Harm Hilvers
none Details | Review
Switch play and previous button (also in fullscreen) (2.15 KB, patch)
2007-01-13 09:11 UTC, Harm Hilvers
accepted-commit_after_freeze Details | Review
Old button sequence (58.58 KB, image/png)
2007-01-13 09:13 UTC, Harm Hilvers
  Details
New button sequence (58.46 KB, image/png)
2007-01-13 09:13 UTC, Harm Hilvers
  Details
Old button sequence - full screen (209.41 KB, image/png)
2007-01-13 09:14 UTC, Harm Hilvers
  Details
New button sequence - full screen (209.39 KB, image/png)
2007-01-13 09:14 UTC, Harm Hilvers
  Details

Description Jorn Baayen 2005-01-14 03:54:15 UTC
Three random UI suggestions:

1. Might be nice to put the play/pause button on the far left (easier to reach,
Fitt's law), and make it a bit bigger, as well as a toggle (after it all, it
toggles playback) - this is how Muine does it, see
http://muine.gooeylinux.org/muine.png.

2. Is the playlist button in the "toolbar" really needed? It seems like a
feature hardly anybody uses, and therefore perhaps unnecessary in the toolbar.
(Is the playlist feature used/needed at all..?)

3. Using jimmac's new volume icons in gnome-icon-theme for the volume control
would look a bit nicer.
Comment 1 Alan Horkan 2005-02-11 21:17:53 UTC
It is generally recommended to put one request per bug report but I expect the
developers will ask if they want to split this up.  

It makes a lot of sense to me to put the Play button at the left edge.  Real
Player does that too.  I suppose the current layout is was based on standard
physical players which tend to have Back and Forwards at the edges but since on
a computer we have a slider those buttons are not so important.  

I'd also like a bigger Play button but I think a more elegant way to implement
it would be to do it as a proper Tool bar (like gst-player did) rather than as a
row of buttons.  By using a toolbar you and I could have our larger buttons by
showing the text labels, and other users could have the more compact layout by
leaving them off.  (I decided to resist the temptation to file a seperate bug
report though.)
Comment 2 Tiago Cogumbreiro 2005-04-13 10:47:57 UTC
I think the playlist is used. When using playlist to view movies that are
splitted in two or three files or even TV series. Totem can also be used an
audio player and in that case the playlist is essential.

On regards on using the toolbar seems to be a very good enhancement. The same
thing could be applied to the playlist.
Comment 3 Karel Demeyer 2005-05-27 13:13:24 UTC
I use Totem as a music player on a daily basis and I use the playlists a lot,
it's a very good thing to have that buttin there imho.
Comment 4 Bastien Nocera 2007-01-05 12:36:48 UTC
Took a while, but I'll reply

(In reply to comment #0)
> Three random UI suggestions:
> 
> 1. Might be nice to put the play/pause button on the far left (easier to reach,
> Fitt's law), and make it a bit bigger, as well as a toggle (after it all, it
> toggles playback) - this is how Muine does it, see
> http://muine.gooeylinux.org/muine.png.

The toggle was already tested, and it really doesn't work well for Totem. See bug #162949.

> 2. Is the playlist button in the "toolbar" really needed? It seems like a
> feature hardly anybody uses, and therefore perhaps unnecessary in the toolbar.
> (Is the playlist feature used/needed at all..?)

It's now "Sidebar" and hosts the properties tab as well.

> 3. Using jimmac's new volume icons in gnome-icon-theme for the volume control
> would look a bit nicer.

Already done.

What's left is moving the play button to the left, which is a pretty good idea actually (maybe making it slightly bigger than prev/next as well).
Comment 5 Harm Hilvers 2007-01-12 23:12:47 UTC
Created attachment 80156 [details] [review]
Switch play and previous button

This patch switches the Play and Previous button.

For some reason, even without this patch, the Play, Previous and Next buttons don't have tooltips. Totem 2.16.x does have tooltips for this button. Shoould I file a bug for this?
Comment 6 Bastien Nocera 2007-01-13 00:15:14 UTC
> For some reason, even without this patch, the Play, Previous and Next buttons
> don't have tooltips. Totem 2.16.x does have tooltips for this button. Shoould I
> file a bug for this?

That must be a side-effect of switching to GtkAction for the menus, and most of the buttons. Please do file another bug.

Do you have screenshots in windowed/fullscreen mode showing the difference?
Comment 7 Harm Hilvers 2007-01-13 09:11:40 UTC
Created attachment 80163 [details] [review]
Switch play and previous button (also in fullscreen)

Hmz, I forgot to include the patch for the controls in fullscreen. They're also switched now. So, when you apply this patch, both the Play and Previous controls in the main window and in fullscreen are switched.

Screenshots are coming up.
Comment 8 Harm Hilvers 2007-01-13 09:13:24 UTC
Created attachment 80164 [details]
Old button sequence
Comment 9 Harm Hilvers 2007-01-13 09:13:59 UTC
Created attachment 80165 [details]
New button sequence
Comment 10 Harm Hilvers 2007-01-13 09:14:39 UTC
Created attachment 80166 [details]
Old button sequence - full screen
Comment 11 Harm Hilvers 2007-01-13 09:14:58 UTC
Created attachment 80167 [details]
New button sequence - full screen
Comment 12 Bastien Nocera 2007-01-13 11:48:27 UTC
Looks good.
It will go first thing into 2.19.x, as we are on a freeze now, and it's far too late to update the screenshots in the docs.
Comment 13 Bastien Nocera 2007-03-26 22:22:22 UTC
2007-03-26  Bastien Nocera  <hadess@hadess.net>

        * src/totem.c: (totem_callback_connect): Patch from Harm Hilvers
        <harm@tweakers.net> to switch the Play button to be at the leftmost
        (Closes: #164037)