After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 164036 - Having a "DVD menu" button or something similar in fullscreen mode would be nice
Having a "DVD menu" button or something similar in fullscreen mode would be nice
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
0.100
Other Linux
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2005-01-14 03:48 UTC by Jorn Baayen
Modified: 2008-09-21 07:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
not-yet-working patch (6.15 KB, patch)
2008-01-20 05:06 UTC, Patrick Hulin 		rejected Details | Review
yet another non-working patch (3.53 KB, patch)
2008-01-21 22:49 UTC, Patrick Hulin 		none Details | Review
Working patch (4.12 KB, patch)
2008-08-22 15:15 UTC, Bastien Nocera 		committed Details | Review

Description Jorn Baayen 2005-01-14 03:48:43 UTC 
Having a "DVD menu" button or something similar in fullscreen mode would be
nice. This for changing subtitles or audio on the fly without having to leave
fullscreen mode.
Comment 1 Ronald Bultje 2005-01-14 09:43:26 UTC 
I don really like the idea of cluttering the fullscreen UI. Would quickkeys (the
same ones as assigned to the menu items) be OK?
Comment 2 Bastien Nocera 2005-01-14 09:54:12 UTC 
The menu items that have shortcuts already work in fullscreen. We could add some
sub-menus to the context menu in fullscreen to switch subtitles/audio tracks.
Comment 3 Jorn Baayen 2005-01-14 11:51:28 UTC 
That'd be nice. Another idea I had, not sure how good or bad, would be to show
the menubar in fullscreen when the mouse moves, just like the bottom bar.
Comment 4 Bastien Nocera 2005-01-16 02:48:30 UTC 
Jorn, hmm, wouldn't pressing 'M' be enough actually?
Comment 5 Jorn Baayen 2005-01-16 13:18:46 UTC 
For me, yes. For most people? No, as most never use keyboard shortcuts.
Comment 6 Bastien Nocera 2007-01-05 11:44:14 UTC 
It should actually be really straight forward to do now that we use GtkAction on trunk.

I would show "Menu" and the subtitles and languages sub-menus when a DVD is playing.
Comment 7 Patrick Hulin 2008-01-20 05:06:25 UTC 
Created attachment 103237 [details] [review]
not-yet-working patch

So this patch will get the menu to show... but if you click on it, it disappears. Not sure why this is happening/how to fix it.
Comment 8 Bastien Nocera 2008-01-21 11:03:58 UTC 
(In reply to comment #7)
> Created an attachment (id=103237) [edit]
> not-yet-working patch
> 
> So this patch will get the menu to show... but if you click on it, it
> disappears. Not sure why this is happening/how to fix it.

Don't use another popup, but rather add subtitles and audio tracks actions to the right-click popup menu.
Comment 9 Patrick Hulin 2008-01-21 22:49:05 UTC 
Created attachment 103379 [details] [review]
yet another non-working patch

Gets a segfault...
Comment 10 Bastien Nocera 2008-08-22 15:15:06 UTC 
Created attachment 117228 [details] [review]
Working patch

This should work. Please test, and I'll commit it for 2.26.
Comment 11 Bastien Nocera 2008-09-21 07:35:50 UTC 
2008-09-21  Bastien Nocera  <hadess@hadess.net>

	* data/totem.ui:
	* src/totem-menu.c (add_lang_action), (create_lang_actions),
	(totem_languages_update), (totem_subtitles_update): Add the
	subtitle and languages menus to the fullscreen popup as well
	(Closes: #164036)