After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 163917 - [CYGWIN] Make check fails due to abicheck.sh failure
[CYGWIN] Make check fails due to abicheck.sh failure
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.6.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-01-13 10:07 UTC by Roger Leigh
Modified: 2005-01-13 15:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk-2.6.1-abicheck.diff (992 bytes, patch)
2005-01-13 10:08 UTC, Roger Leigh 		none Details | Review
gtk-2.6.1-configure-abicheck.diff (571 bytes, patch)
2005-01-13 12:25 UTC, Roger Leigh 		none Details | Review

Description Roger Leigh 2005-01-13 10:07:58 UTC 
abicheck.sh should not be run in a Cygwin environment.  Currently, it's not even
UNIX-compatible, since it hardcodes the library name (not all UNIX systems
support shared libraries, or have DSOs ending with .so).  The attached patch
makes this test Linux-specific, as has been previously done with glib.


Regards,
Roger
Comment 1 Roger Leigh 2005-01-13 10:08:35 UTC 
Created attachment 35938 [details] [review]
gtk-2.6.1-abicheck.diff

Make abicheck.sh only run on Linux platforms.
Comment 2 Roger Leigh 2005-01-13 12:25:59 UTC 
Created attachment 35947 [details] [review]
gtk-2.6.1-configure-abicheck.diff

The first patch didn't include the necessary configure logic.  I've put this in
this additional patch.	This is taken from the GLib 2.6.1 configure.in.
Comment 3 Matthias Clasen 2005-01-13 15:19:36 UTC 
2005-01-13  Matthias Clasen  <mclasen@redhat.com>

	* configure.in: Add an OS_LINUX conditional.

	* gdk/Makefile.am (TESTS):
	* gdk-pixbuf/Makefile.am (TESTS):
	* gtk/Makefile.am (TESTS): Only run abicheck on Linux.  (#163917,
	Roger Leigh)