After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 163801 - [PATCH] mem leak in xml registry loading
[PATCH] mem leak in xml registry loading
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-12 13:09 UTC by Luca Ognibene
Modified: 2005-01-17 12:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mem leak patch (419 bytes, patch)
2005-01-12 13:18 UTC, Luca Ognibene
none Details | Review
second try (324 bytes, patch)
2005-01-13 11:27 UTC, Luca Ognibene
none Details | Review

Description Luca Ognibene 2005-01-12 13:09:32 UTC
in gst_xml_registry_load a new reference to a markup_parse_context is craeted
and it's never freed. This patch frees it in _close_func
Comment 1 Luca Ognibene 2005-01-12 13:18:57 UTC
Created attachment 35892 [details] [review]
mem leak patch
Comment 2 Luca Ognibene 2005-01-13 10:00:49 UTC
don't commit it. it creates a warning in gst-register. 
Comment 3 Luca Ognibene 2005-01-13 11:27:19 UTC
Created attachment 35945 [details] [review]
second try
Comment 4 Luca Ognibene 2005-01-13 11:29:59 UTC
btw, why gst_xml_registry_load use a xmlregitry->context and the other functions
use a local context ? The global context is never used outside
gst_xml_registry_load ... 
This patch frees the context in the load function
Comment 5 Ronald Bultje 2005-01-17 12:53:16 UTC
Applied, thanks. I don't know why the variable is stored in a structure, but I
assume it's useful somehow.