After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 163309 - [PATCH] typefinding for formats used by libsndfile
[PATCH] typefinding for formats used by libsndfile
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other All
: Normal enhancement
: 0.8.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-08 07:52 UTC by Steve Baker
Modified: 2005-01-17 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libsndfile typefind functions (4.36 KB, patch)
2005-01-08 07:53 UTC, Steve Baker 		none Details | Review
updated typefind patch (5.22 KB, patch)
2005-01-09 02:36 UTC, Steve Baker 		none Details | Review
libsndfile documentation patch to docs/random/mimetypes (1.08 KB, patch)
2005-01-09 02:38 UTC, Steve Baker 		none Details | Review
patch to advanced-types.xml (3.00 KB, patch)
2005-01-13 07:59 UTC, Steve Baker 		none Details | Review

Description Steve Baker 2005-01-08 07:52:03 UTC 
The attached patch adds typefinding functions for formats used by libsndfile
which also have test files here:
http://www.mega-nerd.com/tmp/SoundFileCollection-20041231-1305.tgz
All audio files in this tarball should now be correctly detected except for
mono24.vox which is basically raw.

All new mime-types are of the form audio/x-foo. No testing for false positives
has been done.

The long term plan is to be able to playback any libsndfile supported file with
totem - this patch is the first step. I don't currently have commit access so
could whoever approves this patch please commit?
Comment 1 Steve Baker 2005-01-08 07:53:39 UTC 
Created attachment 35651 [details] [review]
libsndfile typefind functions
Comment 2 Ronald Bultje 2005-01-08 09:44:38 UTC 
Can you document the added formats so I can add them to the PWG?
Comment 3 Steve Baker 2005-01-09 02:36:53 UTC 
Created attachment 35697 [details] [review]
updated typefind patch

This patch includes support for files that denote endianess by reversing the
special string
Comment 4 Steve Baker 2005-01-09 02:38:34 UTC 
Created attachment 35698 [details] [review]
libsndfile documentation patch to docs/random/mimetypes

Update to docs/random/mimetypes to include new mimetypes. Ronald, is this
enough documentation for you?
Comment 5 Ronald Bultje 2005-01-09 09:06:14 UTC 
The official doc types are in gstreamer/docs/pwg/advanced-types.xml, can you add
it there instead?
Comment 6 Steve Baker 2005-01-13 07:59:09 UTC 
Created attachment 35931 [details] [review]
patch to advanced-types.xml
Comment 7 Ronald Bultje 2005-01-17 13:48:03 UTC 
Applied. I assume you'll put the patch for sfdec in a separate report, so
closing this.