GNOME Bugzilla – Bug 163165
Bad parsing for "user" in fstab
Last modified: 2018-08-17 13:51:49 UTC
This bug has been opened here: https://bugzilla.ubuntu.com/4023 "Nautilus will show any mounts with the word "user" in their fstab line as drives on the desktop. Unfortunately, one of the samba options is "username", so any samba exports mounted as a particular user will be shown on the desktop rather than just slotted into the directory tree as normal mounts."
gnome-vfs issue, reassigning.
Created attachment 45862 [details] [review] Proposed Patch (HEAD) mntent indeed matches all strings beginning with "name", so we have to filter this one out.
...beginning with "user", I mean.
Up as there is a patch a no comments for a year. Is this bug still valid ? Has the bug been commited ?
Thanks for pinging us. The current semantics are actually a bit odd, because hasmntopt() does substring matching, and the patch just special-cases particular cases. I'll look into it. Reopening, assigning to myself.
Created attachment 62678 [details] [review] Proposed (not really tested) patch The attached patch adds a getmntopt_strcmp helper which doesn't do substring matching but matches keys where each mntopt is either "key=value" or "key". Requires testing, feedback appreciated.
Did the patch get some attention?
I know gvfs is on the rails, but would be nice to have some feedback on this patch if possible. Thanks for your attention cheers
gnome-vfs got deprecated in 2008. gnome-vfs is not under active development anymore and had its last code changes in 2011. Its codebase has been archived: https://gitlab.gnome.org/Archive/gnome-vfs/commits/master gio (in glib) and gvfs are its successors. See https://developer.gnome.org/gio/stable/ch33.html and https://people.gnome.org/~gicmo/gio-migration-guide/ for porting info. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Feel free to open a task in GNOME Gitlab if the issue described in this task still applies to a recent + supported version of glib/gio/gvfs. Thanks!