After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 163161 - [pngenc] only supports video/x-raw-rgb,bits=24,depth=24
[pngenc] only supports video/x-raw-rgb,bits=24,depth=24
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-06 19:35 UTC by Gergely Nagy
Modified: 2005-01-07 10:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing the bug (3.55 KB, patch)
2005-01-06 21:58 UTC, Gergely Nagy
none Details | Review

Description Gergely Nagy 2005-01-06 19:35:46 UTC
gst-launch filesrc location=png-with-alpha.png ! pngdec ! pngenc ! filesink
location=foo.png

This will not work, as pngenc cannot negotiate with pngdec. If I add an !
alphacolor ! ffmpegcolorspace after pngdec, the file gets saved, but is skewed
(because - imo - it really is 32bits, but pngenc treats it as if it were 24 only)

Looking at ext/libpng/gstpngenc.c, I think I may be able to come up with a patch
soonish.
Comment 1 Gergely Nagy 2005-01-06 21:58:22 UTC
Created attachment 35583 [details] [review]
Patch fixing the bug

This one add support for video/x-raw-rgb,depth=32 to pngenc. Quite simple,
really.

First, the patch makes pngenc use a different way to set up its pads (that was
needed to add GST_VIDEO_CAPS_RGBA support), then teaches the png_set_iHDR call
in  gst_pngenc_chain() about PNG_COLOR_TYPE_RGBA.
Comment 2 Ronald Bultje 2005-01-07 10:27:04 UTC
Applied, thanks. Also renamed mime to image/png, since that's the official one.