After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162902 - Keyboard shortcuts are not saved
Keyboard shortcuts are not saved
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-04 09:48 UTC by Wouter Bolsterlee (uws)
Modified: 2006-04-27 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix this bug (215 bytes, patch)
2006-01-17 01:39 UTC, Scott Bronson
none Details | Review
Properly formatted fix for this bug (406 bytes, patch)
2006-01-17 02:22 UTC, Scott Bronson
none Details | Review

Description Wouter Bolsterlee (uws) 2005-01-04 09:48:07 UTC
Gconf-editor allows keybindings to be altered by hovering over a menu item and
pressing a new keycombo. This works fine, but the new keyboard shortcuts are not
loaded from/saved to a GTK accelerator map dump file, so they do not persist.

Steps to reproduce (obvious, but anyway):

1. Make sure you have dynamic keybindings enabled
2. Open gconf-editor
3. Open the menu
4. Hover over a menu option
5. Press a new combo (eg. ctrl-r)
6. Close the menu
7. Press ctrl-r
8. See the expected result
9. Close gconf-editor
10. Open gconf-editor again
11. Notice that the newly created keybinding is reset to its default value
Comment 1 Wouter Bolsterlee (uws) 2005-03-14 19:45:15 UTC
Please have a look at this issue again. (Ctrl-S to open a new window is really
annoying). Thanks.
Comment 2 Steve George 2005-03-27 23:28:13 UTC
Hi,

Enabled dynamic keybindings by adding gtk-can-change-accels=1
 to ~/.gtkrc-2.0

In GNOME 2.10 under Ubuntu hoary-preview this behaviour still remains.  The
keybinding is not permanently fixed to the new version.  This was also the case
with the System Log Viewer.

I've never heard of this feature before so I don't know what the expected
behabious is supposed to be.  A search on google doesn't turn up any suitable
information or a standard.  Sorry - I can't confirm it as a bug without knowing
what it's supposed to do!

Thanks,

Steve
Comment 3 Wouter Bolsterlee (uws) 2005-06-02 19:42:14 UTC
This bug is still annoying ;)  The accelerator map should be saved to disc
before quitting the application. Please read
http://developer.gnome.org/doc/API/2.0/gtk/gtk-Accelerator-Maps.html#gtk-accel-map-save
for information on how to fix this usability bug.
Comment 4 Scott Bronson 2006-01-17 01:39:35 UTC
Created attachment 57508 [details] [review]
Patch to fix this bug

Couldn't be easier...
Comment 5 Scott Bronson 2006-01-17 02:20:04 UTC
Comment on attachment 57508 [details] [review]
Patch to fix this bug

Index: main.c
===================================================================
RCS file: /cvs/gnome/gconf-editor/src/main.c,v
retrieving revision 1.12
diff -p -u -b -B -r1.12 main.c
--- main.c  5 Nov 2004 13:45:52 -0000   1.12
+++ main.c  17 Jan 2006 02:18:05 -0000
@@ -95,6 +95,8 @@ main (gint argc, gchar **argv)
    poptFreeContext (pctx);

    gtk_main ();
+
+   gnome_accelerators_sync();

    return 0;
 }
Comment 6 Scott Bronson 2006-01-17 02:22:57 UTC
Created attachment 57510 [details] [review]
Properly formatted fix for this bug

Sorry -- forgot that I had deleted my .cvsrc.  It's the same patch, just this time with context.
Comment 7 Wouter Bolsterlee (uws) 2006-03-03 21:45:00 UTC
Can someone commit this patch? Thanks.
Comment 8 Wouter Bolsterlee (uws) 2006-04-27 21:19:28 UTC
I've committed this to CVS, since this module seems basically unmaintained. Please let me know if you don't like this.

2006-04-27  Wouter Bolsterlee  <uws+gnome@xs4all.nl>

    * src/main.c: Call gnome_accelerators_sync() to save the keyboard
    shortcuts on exit. Fixes bug #162902.