GNOME Bugzilla – Bug 162884
[faad] stores data in struct zeroed later on
Last modified: 2005-03-25 21:35:30 UTC
gstfaad.c stores data in faacDecFrameInfo struct, which is memset() to 0 each time a frame is decoded. Therefore checks for renegotation are moot. Would be nice to fix that, marking it here since my CVS tree is a mess atm, will do that later
The checks for renegotiation compare the new, updated values to the ones stored in our own struct. This is perfectly valid. You probably didn't sleep enough when looking at this. We do store the information in there for sanity purposes, which is simply for if ever they would add a if (some_condition) return_immediately; to the decode function. Then we don't do anything else but just return immediately ourselves, too... Marking NOTABUG.