After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162884 - [faad] stores data in struct zeroed later on
[faad] stores data in struct zeroed later on
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-01-04 01:52 UTC by Maciej Katafiasz
Modified: 2005-03-25 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Maciej Katafiasz 2005-01-04 01:52:36 UTC 
gstfaad.c stores data in faacDecFrameInfo struct, which is memset() to 0 each
time a frame is decoded. Therefore checks for renegotation are moot. Would be
nice to fix that, marking it here since my CVS tree is a mess atm, will do that
later
Comment 1 Ronald Bultje 2005-03-25 21:35:30 UTC 
The checks for renegotiation compare the new, updated values to the ones stored
in our own struct. This is perfectly valid. You probably didn't sleep enough
when looking at this.

We do store the information in there for sanity purposes, which is simply for if
ever they would add a if (some_condition) return_immediately; to the decode
function. Then we don't do anything else but just return immediately ourselves,
too...

Marking NOTABUG.