After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162541 - Missing mnemonics in Rotate tool window
Missing mnemonics in Rotate tool window
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
2.2.x
Other All
: Low enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2004-12-30 14:23 UTC by Marcin Orlowski
Modified: 2008-01-15 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adds missing mnemonics (and makes info dialogs support mnemonics) (12.89 KB, patch)
2005-09-03 18:30 UTC, david gowers
none Details | Review

Description Marcin Orlowski 2004-12-30 14:23:27 UTC
Window: Layer -> Transform -> Arbitrary rotate

Some gadgets like "Angle", "Center X" and "Center Y" lacks keyboard shortcuts.
Comment 1 Sven Neumann 2004-12-30 15:34:26 UTC
The proper term is mnemonic, not keyboard shortcut.
Comment 2 david gowers 2005-09-03 18:26:41 UTC
The following patch adds the following mnemonics: 

* rotate : angle, x/y center 
* scale : w,h, aspect ratio 
* shear : magnitude x,y 
* desaturate: desaturate.  (wanted to do the main types, but they are enum.)
* new layer: w,h. (wanted to do fill type but they are enum.)
* layers merge: expand, clip to image, clip to bottom layer.

touched files:
    app/dialogs/layer-options-dialog.c
    app/dialogs/desaturate*.c
    app/dialogs/info-dialog.c (support mnemonics)
    app/tools/gimp[scale|rotate|shear]tool.c
    app/dialogs/image-merge-layers-dialog.c
Comment 3 david gowers 2005-09-03 18:30:53 UTC
Created attachment 51767 [details] [review]
adds missing mnemonics (and makes info dialogs support mnemonics)

All changes are trivial except to info-dialog.c.
Finding the Spinbutton widget belonging to a GimpSizeEntry is hackish.
I see no way to better implement it though.
Otherwise it's clean.
Comment 4 Michael Natterer 2005-09-03 18:49:43 UTC
Eeek, yes that's hackish :) No way this will go to CVS, please use
gimp_size_entry_get_help_widget() (yes, this functions is
probably misnamed).

Apart from that, patching info-dialog.c is pointless, because
it will go away before 2.4.

Also, what is AKUMA?
Comment 5 Sven Neumann 2006-10-18 10:29:27 UTC
2006-10-18  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpwidgets.c (find_mnemonic_widget): special
	case GimpSizeEntry and use the last entry.

	* app/tools/gimprotatetool.c
	* app/tools/gimpsheartool.c: added mnemonics (bug #162541).