After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162403 - Quotes appear as doubled escaped
Quotes appear as doubled escaped
Status: RESOLVED FIXED
Product: website
Classification: Infrastructure
Component: art.gnome.org (obsolete)
current
Other Linux
: Normal minor
: ---
Assigned To: art.gnome.org maintainers
art.gnome.org maintainers
: 311537 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-12-28 21:25 UTC by Brian Jørgensen
Modified: 2005-07-26 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Brian Jørgensen 2004-12-28 21:25:57 UTC
1. Visit the page http://art.gnome.org/themes/icon/758/
2. See that ' is displayed as \'

Either the author has submitted the art description with the quote escaped or
the submition/display PHP code does not handle the escaping correctly (proberly
a addslashes too much or a stripslashes missing)

Merry christmas and a happy new year.
Comment 1 Brian Jørgensen 2005-03-25 17:54:00 UTC
The bug still appears at

http://art.gnome.org/themes/metacity/9/
Comment 2 Thomas Wood 2005-03-25 23:53:32 UTC
Thanks for filing this bug. I'm currently trying to root out all the places that cause this bug to appear, 
whilst stilling making sure the sql code is safe.
Comment 3 James 2005-03-31 17:09:10 UTC
echo "stripslashes(data)"; 
would work, I think - that way, the slashes are stored in the database and only
removed when displayed.
Comment 4 Thomas Wood 2005-03-31 18:00:28 UTC
The problem is that it is a gnome.org requirement that we validate all text before it is used in mysql 
queries. In the case where the data is normal strings, such as descriptions or comment), the strings 
need to be escaped before they are used within a mysql query. The slashes should not be stored in the 
database. Unfortunatly, it seems that in the current code, sometimes the data is getting escaped more 
times than expected.
Comment 5 Thomas Wood 2005-07-14 18:36:05 UTC
This should be fixed now since art.gnome.org should use its custom escape function to determine 
whether to add slashes to strings or not.
Comment 6 Thomas Wood 2005-07-26 16:47:37 UTC
*** Bug 311537 has been marked as a duplicate of this bug. ***