After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162276 - [build] gstregistry.h and gstxmlregistry.c don't build with mingw
[build] gstregistry.h and gstxmlregistry.c don't build with mingw
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal blocker
: 0.8.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-26 19:56 UTC by Vincent Torri
Modified: 2005-01-05 11:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch for gstregistrery.h (895 bytes, patch)
2005-01-03 20:03 UTC, Vincent Torri 		none Details | Review
proposed patch for gstxmlregistry.c (352 bytes, patch)
2005-01-03 20:04 UTC, Vincent Torri 		none Details | Review

Description Vincent Torri 2004-12-26 19:56:27 UTC 
When built with mingw, these files ask for S_IRGRP, S_IXGRP, S_IROTH and
S_IXOTH, which are not defined in mingw

in gstxmlregistry.c, line 322, it suffices to replace 
#ifdef _MSC_VER
by
#ifdef _WIN32

and in gstregistrery.h, line 39, replace

#define REGISTRY_DIR_PERMS (S_ISGID | \
                            S_IRUSR | S_IWUSR | S_IXUSR | \
	  	            S_IRGRP | S_IXGRP | \
			    S_IROTH | S_IXOTH)
by

#if defined(_WIN32) && defined(__MINGW32__)
#define REGISTRY_DIR_PERMS (S_ISGID | \
                            S_IRUSR | S_IWUSR | S_IXUSR)
#else
#define REGISTRY_DIR_PERMS (S_ISGID | \
                            S_IRUSR | S_IWUSR | S_IXUSR | \
    	  	            S_IRGRP | S_IXGRP | \
			    S_IROTH | S_IXOTH)
#endif

the same fix has to be done for REGISTRY_FILE_PERMS (line 44)
Comment 1 Stephane Loeuillet 2004-12-27 13:03:06 UTC 
could you provide this in the form of a "diff -u" patch please ?
Comment 2 Vincent Torri 2005-01-03 20:03:14 UTC 
Created attachment 35402 [details] [review]
proposed patch for gstregistrery.h
Comment 3 Vincent Torri 2005-01-03 20:04:16 UTC 
Created attachment 35403 [details] [review]
proposed patch for gstxmlregistry.c
Comment 4 Ronald Bultje 2005-01-05 11:15:51 UTC 
Got it, thanks.