After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162243 - Muine fails to load MP3's with large ID3 tags
Muine fails to load MP3's with large ID3 tags
Status: RESOLVED FIXED
Product: muine
Classification: Other
Component: general
trunk
Other Linux
: Normal major
: ---
Assigned To: Muine Maintainers
Muine Maintainers
: 138968 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-12-26 04:42 UTC by Brian Kerrick Nickel
Modified: 2006-09-29 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for bug 162243 (993 bytes, patch)
2005-05-29 00:55 UTC, Samuel Kaufman 		none Details | Review
The fix without the mistakes (1008 bytes, patch)
2005-05-29 02:33 UTC, Samuel Kaufman 		none Details | Review
Same patch, but universal diff (-u) and applied to main dir (1.56 KB, patch)
2005-06-07 07:27 UTC, Brian Kerrick Nickel 		none Details | Review
Possible different solution (1.76 KB, patch)
2005-06-14 14:23 UTC, Jorn Baayen 		none Details | Review

Description Brian Kerrick Nickel 2004-12-26 04:42:55 UTC 
Since EasyTag 1.99.2 was released, I've been embedding my album covers in my
MP3's. These covers range from 3KB to 150KB and there may be several per file.
Muine fails to load tags with larger tags. I've noticed files with small tags,
around the 10KB range being loaded and files in the 40KB range failing to load.
There may be a cap in the id3 reader at 16 or 32KB or another bug.

The tags loaded successfully in Rhythmbox w/ GStreamer and Totem w/ Xine.
Comment 1 Kevin Duffus 2005-01-07 21:35:53 UTC 
confirming. after seeing this bug i modified some of my files to reduced the
embedded image sizes (from ~200KB to ~25KB) and these files now show up in
muine's database.
Comment 2 Samuel Kaufman 2005-05-29 00:55:38 UTC 
Created attachment 46989 [details] [review]
Fix for bug 162243

I was having the same problem.	Fixed, now.  (Please tell me if I messed up the
file... this is my first patch to an OSS project.)

This patch also removes some useless code under /* If we haven't found
anything, try again with 8 more kB */.
Comment 3 Samuel Kaufman 2005-05-29 02:33:13 UTC 
Created attachment 46990 [details] [review]
The fix without the mistakes

The last one just shows how long it's been since I've written any C.  Sorry
about that.  This is the one that should be commited.
Comment 4 Brian Kerrick Nickel 2005-06-07 07:27:32 UTC 
Created attachment 47365 [details] [review]
Same patch, but universal diff (-u) and applied to main dir

Same patch, but this should be easier to apply.
Comment 5 Jorn Baayen 2005-06-14 14:23:28 UTC 
Created attachment 47756 [details] [review]
Possible different solution

Does this solve the problem ?
Comment 6 Gordon Ingram 2005-07-20 00:57:44 UTC 
It solves the problem for me applied against the current CVS. I haven't tested
it with really large embedded images though, just ones that are failing with the
current Muine release (0.8.3).
Comment 7 Rafael Rodrigues Rezende 2006-04-21 18:56:28 UTC 
Jorn's patch works for me against CVS.

I've tested it with two albums and a file with a 1 MB cover image.
Comment 8 Peter Johanson 2006-05-10 05:44:38 UTC 
Ok, I've just commited this to CVS. Am going to do another pre-release and hopefully get more testing on this that way before this hits in a real release. Marking this FIXED, will re-open if this still doesn't fix the issue for everyone.
Comment 9 Wouter Bolsterlee (uws) 2006-09-29 15:43:37 UTC 
*** Bug 138968 has been marked as a duplicate of this bug. ***