After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 162093 - possible leak of a gtk_style in translucency code
possible leak of a gtk_style in translucency code
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: trash applet
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-23 14:46 UTC by Vincent Noel
Modified: 2005-03-02 03:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vincent Noel 2004-12-23 14:46:21 UTC 
Most of the translucency support in applets is derived from this part of code in
the trashapplet :

	case PANEL_PIXMAP_BACKGROUND:
		style = gtk_style_copy (GTK_WIDGET (window_menu->menu_bar)->style);
		if (style->bg_pixmap[GTK_STATE_NORMAL])
			g_object_unref (style->bg_pixmap[GTK_STATE_NORMAL]);
		style->bg_pixmap[GTK_STATE_NORMAL] = g_object_ref (pixmap);
		gtk_widget_set_style (GTK_WIDGET (window_menu->menu_bar), style);
		break;

According to comments in bug 160450, this could be a leak as the gtk_style is
never unref'd. If this is actually the case, this would have to be corrected in
all applets that used the same code.
Comment 1 Danielle Madeley 2005-01-04 07:01:24 UTC 
Are you able to confirm this with valgrind?
Comment 2 Vincent Untz 2005-02-26 14:47:11 UTC 
Davyd: I could confirm this with valgrind. And I fixed this in the applets of
gnome-panel.
Comment 3 Danielle Madeley 2005-02-26 15:21:16 UTC 
Can you link to reference code (perhaps the diff from CVS)? I want to make sure
we get it right, given how close we are to freeze. Thanks.
Comment 5 Vincent Noel 2005-03-01 18:15:34 UTC 
Is it too late to make the change now ? I need to apply the same fix to the
gnome-dictionary applet.
Comment 6 Vincent Untz 2005-03-01 18:21:09 UTC 
You should probably ask the release team for approval.
Comment 7 Danielle Madeley 2005-03-02 03:42:03 UTC 
This is fixed in g-a, the bug wasn't closed.