GNOME Bugzilla – Bug 161905
Don't hard code file name into Nautilus message
Last modified: 2005-03-25 14:14:04 UTC
#. name, stock id, label #: src/file-manager/fm-directory-view.c:5695 msgid "Run or manage scripts from ~/.gnome2/nautilus-scripts" Please do NOT hard code file names or directory names into translateable messages! The next time the path or file name changes, all 72 translations will have to be updated. That's certainly not good design, and a pain for translators.
Can someone on the i18n team whip up a quick patch for this, you think? [Not marking high priority because while I understand the sentiment, I'm pretty sure that location has not changed since nov/dec. 2001.]
It changed recently; previously the message was pointing at ~/Nautilus/scripts something. However, I too suspect that it is unlikely to soon change again, but still, when it does I and many other translators are going to start pulling our hairs again in frustration. Furthermore, in the mean time there is always the danger of some translator actually translating the path/filename by accident.
Created attachment 37923 [details] [review] Proposed patch This patch is slightly complicated by the fact that all the other menu actions are declared in a static array. In order to dynamically create the tooltip for the scripts action, it had to be brought out of the nice array and created manually.
Comment on attachment 37923 [details] [review] Proposed patch Looks good - Perhaps using char instead of gchar would make it more consistant with the rest of fm-directory-view. It'll have to wait till the branch due to the string change though. Thanks.
Thanks; I don't have CVS write access though. Please commit this for me after the branch.
2005-03-25 Martin Wehner <martin.wehner@gmail.com> * src/file-manager/fm-directory-view.c: (real_merge_menus): Remove hard coded script directory path from tooltip message. Fixes bug #161905. Patch from Michael Terry <mike@mterry.name>