GNOME Bugzilla – Bug 161859
"Add bookmarks" behavior inconsistent
Last modified: 2005-06-20 13:53:35 UTC
Pre-requisite: You have to browse some folders in nautilus before reproducing this bug. So start nautilus and browse as many folders as possible on your desktop and close nautilus window. Now following steps needs to be executed: 1. Right Click on any folder and select "Browse Folder" 2. Lets say the folder curently you are browsing is /home/test/, now click on Bookmarks->Add Bookmark. 3. Click on Bookmarks->Add Bookmarks again. Repeat this step many number of times. 4. You will find the folders you had browsed earlier (as said in pre-requisite) have been added as the bookmarks and not the current folder which is being browsed. 5. Now close the nautilus window and restart it (as in Step 1.) 6. Click on Bookmarks. You will find the different folders that were added in the bookmarks list are all replaced by the current folder being browsed (which was the expected behavior in the step no. 4 above) I am using the latest nautilus from CVS HEAD.
As specified in Step No.4 in the description, The list of bookmarks shown is not expected. If you click on "Bookmarks->Edit bookmarks" after Step 4. itself you will find the list of bookmarks to be the correct list.
This is really wired ... Guess this not be an intentional behaviour. I'm confirming this bug. Comments?...
Created attachment 35078 [details] [review] Proposed patch This patch resolves this bug and bug#161862 (add bookmark adds location multiple times)
Marking this bug as duplicate of the #161862, as these have the common fix. *** This bug has been marked as a duplicate of 161862 ***
Re-opening this bug, this patch just avoids the entry of duplicate bookmarks. Had a quick look, The cause seems to be different, it seems to maintain all the history nodes. Debugging shows that correct nodes or bookmarked path are being added, but these changes are not reflected immedately in the bookmarks menu. Needs to further debug. Alex: Could you please tell me, does this history of bookmarks help and how? Please comment.
Comment on attachment 35078 [details] [review] Proposed patch Committed via bug 161862.
*** Bug 171254 has been marked as a duplicate of this bug. ***
#171254 has screenshots of the bug
Martin: Does the fix which you have committed fixes this issue ?. Can this history stuff be removed ?. I don't understand why do we need the history ?. It unnecessarily popluates the bookmarks list ;). What happens for remote access protocols ?(ftp, smb, sftp...). Does this history be still valid ? Or we are restricting history stuff to local file system only ? :).
No, the patch just prevents a bookmark from being added twice. Does the bookmark menu have anything to do with the history? What do you mean by "history stuff"?
In nautilus-navigation-window-menus.c:(refresh_go_menu), I find some history nodes are being appended. Guess these play a role in this bug :).
*** Bug 305159 has been marked as a duplicate of this bug. ***
Created attachment 47861 [details] [review] Makes action anmes unique for go/bookmark menu items This really annoying bug is caused by both go menu items and bookmark menu items having the same action name despite having different paths (dunno if this is a bug or a feature in GtkUIManager?). This patch makes the action name unique regardless of its path and thus prevents GtkUIManager getting its knickers in a twist.
You can't have / chars in action names. I fixed this by passing a unique parent id instead.