After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161817 - f-spot cvs doesn't find lcms headers on gentoo
f-spot cvs doesn't find lcms headers on gentoo
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
CVS
Other Linux
: Normal minor
: ---
Assigned To: F-spot maintainers
F-spot maintainers
: 166029 167750 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-12-20 19:50 UTC by Loz
Modified: 2005-02-17 23:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Find header at lcms/lcms.h as well as just lcms.h (1.09 KB, patch)
2004-12-23 17:04 UTC, Loz
none Details | Review
Do what Larry suggested (2.03 KB, patch)
2005-01-24 22:37 UTC, Loz
none Details | Review

Description Loz 2004-12-20 19:50:09 UTC
Need som autotools-fu to locate lcms - Larry says that Novell Desktop doesn't
have a pkg-config file for it yet.

As a workaround use autogen like so:

CPPFLAGS="-I /usr/include/lcms" ./autogen.sh
Comment 1 Loz 2004-12-23 17:04:35 UTC
Created attachment 35168 [details] [review]
Find header at lcms/lcms.h as well as just lcms.h

On my (Gentoo) system, the lcms header is in /usr/include/lcms/lcms.h. The
attached patch will look there too.

I've no idea if there is a more standard way of doing that in autotools.
Comment 2 Larry Ewing 2004-12-26 06:55:52 UTC
I added a similar check already does it fix the problem for you?
Comment 3 Loz 2004-12-27 01:33:07 UTC
Unless I do the CPPFLAGS thing I get (with current anoncvs):

checking for cmsCreate_sRGBProfile in -llcms... yes
checking lcms.h usability... no
checking lcms.h presence... no
checking for lcms.h... no
configure: error: liblcms not found

I think someone on irc mentioned a problem with anoncvs. I'll leave it a couple
of days and check again.
Comment 4 Loz 2004-12-29 22:12:46 UTC
It's still a problem. The code that is in there will only detect a header in
gcc's standard include path. /usr/include/lcms/ is not in that path for me.
Comment 5 Larry Ewing 2005-01-13 16:55:03 UTC
is gentoo messing with the where the package installs the header then?  mine is
defeinitely not in an lcms subdir.
Comment 6 Loz 2005-01-16 20:38:43 UTC
Yes, Gentoo has

make ... includedir="/usr/include/${PN}" ... install

in its build script:
http://www.gentoo.org/cgi-bin/viewcvs.cgi/media-libs/lcms/lcms-1.13.ebuild?rev=HEAD&content-type=text/vnd.viewcvs-markup.
PN will expand to lcms.
Looking back through old ebuilds, it has been that way for at least two and a
half years. I can't find any special reason why, but obviously not supporting it
will annoy any other Gentoo users who try compiling. Eventually Gentoo will have
a build for f-spot, and they can fix their own mess. Up to you if you want to
fix it, I can always work around.

Comment 7 Ernst Sjöstrand 2005-01-21 10:02:39 UTC
Ah, this was allready reported exactly as I would have reported it.

Still a problem with 0.0.6
Comment 8 Larry Ewing 2005-01-23 19:16:26 UTC
what we need is a check for the pkg-config entry and if that fails fall back to
the current header check.
Comment 9 Loz 2005-01-24 22:37:57 UTC
Created attachment 36487 [details] [review]
Do what Larry suggested

Should LCMS_LIBS be in another makefile somewhere?

Guess which source based distro installs an incorrect .pc file :-O
Comment 10 Loz 2005-01-24 22:46:16 UTC
Oh, I made up the minimum version of lcms, does anyone know what it should be?

If anyone wants to track the gentoo bug it is at
http://bugs.gentoo.org/show_bug.cgi?id=79386
Comment 11 Larry Ewing 2005-01-25 09:01:34 UTC
committed, thanks Loz
Comment 12 Loz 2005-01-30 11:44:46 UTC
The gentoo bug has been fixed upstream.
Comment 13 Larry Ewing 2005-02-02 17:01:21 UTC
*** Bug 166029 has been marked as a duplicate of this bug. ***
Comment 14 Larry Ewing 2005-02-17 23:23:22 UTC
*** Bug 167750 has been marked as a duplicate of this bug. ***