After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161737 - Needs to send a _NET_ACTIVE_WINDOW message when clicked on
Needs to send a _NET_ACTIVE_WINDOW message when clicked on
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: gdict
trunk
Other Linux
: High major
: ---
Assigned To: gnome-utils Maintainers
John Fleck
Depends on: 161735
Blocks:
 
 
Reported: 2004-12-19 23:29 UTC by Elijah Newren
Modified: 2005-01-07 19:20 UTC
See Also:
GNOME target: 2.10.0
GNOME version: 2.9/2.10

Attachments
Request focus when clicked on (1.30 KB, patch)
2005-01-07 01:13 UTC, Elijah Newren 		accepted-commit_now Details | Review

Description Elijah Newren 2004-12-19 23:29:28 UTC 
See bug 161735 for more details; basically Metacity won't be focusing the panel
on click unless it receives a _NET_ACTIVE_WINDOW message for the panel.  So, in
order for the dictionary applet to work, it needs to send such a message.
Comment 1 Vincent Noel 2004-12-20 04:15:40 UTC 
And how can the applet do that exactly ? Is there an API already in place ?
Comment 2 Elijah Newren 2004-12-20 04:37:08 UTC 
It's not possible for the applet to do this because it doesn't currently know
the GDK_WINDOW_XID of the panel that contains it.  So bug 161735 must be fixed
first (I already marked it as a dependency...).  Once you have that, you can
call gdk_window_focus(gdk_window_id, timestamp) in the appropriate button press
event.
Comment 3 Elijah Newren 2005-01-07 01:13:43 UTC 
Created attachment 35590 [details] [review]
Request focus when clicked on

This patch fixes the problem, though it depends on the patch in bug 161735
being applied first (and thus being accepted first)...
Comment 4 Elijah Newren 2005-01-07 16:49:19 UTC 
Patch in bug 161735 has been committed; is it okay to commit this patch now?
Comment 5 Vincent Noel 2005-01-07 16:51:34 UTC 
By all means, go ahead ! :)
Comment 6 Elijah Newren 2005-01-07 17:26:36 UTC 
committed.  :)
Comment 7 Elijah Newren 2005-01-07 19:07:26 UTC 
Ooops, as Mark pointed out, I should have updated configure.in to depend on the
latest libpanel-applet.  Okay if I commit the following change?

Index: configure.in
===================================================================
RCS file: /cvs/gnome/gnome-utils/configure.in,v
retrieving revision 1.369
diff -p -u -r1.369 configure.in
--- configure.in        21 Dec 2004 14:34:38 -0000      1.369
+++ configure.in        7 Jan 2005 18:57:01 -0000
@@ -31,7 +31,7 @@ LIBGNOMEUI_REQUIRED=2.5.0
 LIBGLADE_REQUIRED=2.3.0
 LIBBONOBOUI_REQUIRED=2.1.0
 GNOMEVFS_REQUIRED=2.8.4
-LIBPANEL_APPLET_REQUIRED=2.8.0
+LIBPANEL_APPLET_REQUIRED=2.9.4
 LIBGNOMEPRINT_REQUIRED=2.8.0
 LIBGNOMEPRINTUI_REQUIRED=2.8.0
Comment 8 Vincent Noel 2005-01-07 19:11:08 UTC 
Be my guest ;-)
Comment 9 Elijah Newren 2005-01-07 19:20:10 UTC 
ok, done.  Thanks.