After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161568 - pango compilation broken
pango compilation broken
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: High normal
: ---
Assigned To: pango-maint
pango-maint
: 161783 161893 163231 168669 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2004-12-17 18:34 UTC by Vincent Noel
Modified: 2005-03-01 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vincent Noel 2004-12-17 18:34:25 UTC
Compilation of pango (1.8 and CVS) keeps breaking for me with :

pangofc-fontmap.c:27:24: fontconfig.h: No such file or directory
pangofc-fontmap.c: In function `pango_fc_convert_weight_to_fc':
pangofc-fontmap.c:585: error: `FC_WEIGHT_NORMAL' undeclared (first use in this
function)
pangofc-fontmap.c:585: error: (Each undeclared identifier is reported only once
pangofc-fontmap.c:585: error: for each function it appears in.)
make[4]: *** [pangofc-fontmap.lo] Error 1
make[4]: Leaving directory `/home/noel/Documents/install/pango/pango'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/noel/Documents/install/pango/pango'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/noel/Documents/install/pango/pango'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/noel/Documents/install/pango'
make: *** [all] Error 2

I checked and I have the last fontconfig (2.2.96). I even tried reinstall it,
but it still breaks.
Comment 1 Owen Taylor 2004-12-17 18:42:41 UTC
Well, your latest fontconfig definitely isn't in the right place, 
since FC_WEIGHT_NORMAL has been there since before 2.2. But there
does seem to be a bug in the /* fontconfig < 2.2 */ case ...

 return FC_WEIGHT_NORMAL 

should be return FC_WEIGHT_MEDIUM. (If you could test that fix, before
you fix your fontconfig installation, that would be appreciated.)
Comment 2 Vincent Noel 2004-12-17 18:54:56 UTC
That fixed it. Thanks a lot.
I'm dubious wether my fontconfig installation is really broken or not -- I never
had any problem compiling pango since this commit :
http://cvs.gnome.org/viewcvs/pango/pango/pangofc-fontmap.c?r1=1.26&r2=1.27

Anyway, that doesn't really matter, and it compiles now.
Comment 3 Vincent Noel 2004-12-17 19:01:09 UTC
By the way, I checked fontconfig.h (which is correctly located in
/usr/include/fontconfig/) and FC_WEIGHT_NORMAL is indeed defined inside (as an
alias for FC_WEIGHT_REGULAR). I don't really understand what's going on here. Oh
well.
Comment 4 Vincent Noel 2004-12-17 19:04:48 UTC
Ok, this was indeed something strange in my config : I changed

#include <fontconfig/fontconfig.h>

in pangofc-fontmap.h to

#include "/usr/include/fontconfig/fontconfig.h"

and it worked. There's nothing wrong with pango per se. I'm closing this bug.
Comment 5 Owen Taylor 2004-12-17 19:28:39 UTC
No, there is a bug, it's just only with old versions of fontconfig.
You presumably have one in /usr/X11R6 or /usr/local or somewhere else
on your system.
Comment 6 Vincent Noel 2004-12-17 19:39:15 UTC
Yeah, that's exactly it - there was an old
/usr/X11R6/include/fontconfig/fontconfig.h that was picked up before the
/usr/include/fontconfig one and screwed everything up. I just removed it and
everything was fine. I wonder if that was causing any other kind of damage.
Comment 7 Owen Taylor 2004-12-17 19:45:18 UTC
Fri Dec 17 14:37:49 2004  Owen Taylor  <otaylor@redhat.com>

        * pango/pangofc-fontmap.c (pango_fc_convert_weight_to_fc): Use
        FC_WEIGHT_MEDIUM, not FC_WEIGHT_NORMAL in old-fontconfig
        case. (#161568, Vincent Noel)

Comment 8 Owen Taylor 2004-12-20 14:00:05 UTC
*** Bug 161783 has been marked as a duplicate of this bug. ***
Comment 9 Owen Taylor 2004-12-21 15:36:37 UTC
*** Bug 161893 has been marked as a duplicate of this bug. ***
Comment 10 Tristan Van Berkom 2004-12-21 15:51:31 UTC
Strange, I could swear that the bugzilla search for FC_WEIGHT_NORMAL
returned "zarro boogs", oh well; maybe I need to improve my bugzilla
query skills :)

Comment 11 Owen Taylor 2005-01-07 17:04:38 UTC
*** Bug 163231 has been marked as a duplicate of this bug. ***
Comment 12 Owen Taylor 2005-03-01 14:58:07 UTC
*** Bug 168669 has been marked as a duplicate of this bug. ***