GNOME Bugzilla – Bug 161375
should use display name, not email address in bugmails
Last modified: 2005-01-09 14:05:47 UTC
In bugmails, the commenter's email is displayed instead of his real name, like this: ------- Additional Comments From chpe@gnome.org 2004-12-15 08:51 ------- instead of ------- Additional Comment #3 From Christian Persch 2004-12-15 08:51 ------- I think not displaying the email address will address the following problem: bug submitters keep replying directly to me, instead of adding their comment to bugzilla.
Agreed. We also need the all-caps "DO NOT RESPOND TO THIS EMAIL. GO TO <URL> AND ADD YOUR COMMENTS THERE" at the beginning of each email. :-)
Created attachment 35233 [details] [review] Show display name iso email address Patch changes the GetLongDescriptionAsText function in globals.pl to display the real name if it is set. This function is only used in processmail. Adding the comment number is hard to do, so this patch doesn't do that. Additional text at the beginning of the email can be configured by the 'newchangedmail' Bugzilla parameter. This patch also doesn't change the 'bugzilla-gnome@bkor.dhs.org changed:' (shown when changing fields, confirming a bug, etc). I'll do that in a separate patch.
Created attachment 35234 [details] [review] Also show display name in diffs This is a separate patch. This will show the name when changing fields (the 'user@example.com changed:'). Example (currently): user@example.com changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Linux |All Example (after the patch and realname filled in): John Doe changed: What |Removed |Added ---------------------------------------------------------------------------- OS/Version|Linux |All Note that when adding/removing an email address (CC field) it will still show that email address in the 'Removed' or 'Added' parts.
Please apply then retest.
Have committed and retested on test bug 162691. Changed status and added comment with realname set -- realname was correctly shown in email. Cleared realname in preference. Again changed status and added comment -- shows email address. Marking fixed.