After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161375 - should use display name, not email address in bugmails
should use display name, not email address in bugmails
Status: RESOLVED FIXED
Product: bugzilla.gnome.org
Classification: Infrastructure
Component: general
unspecified
Other Linux
: High critical
: ---
Assigned To: Bugzilla Maintainers
Bugzilla Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-15 14:48 UTC by Christian Persch
Modified: 2005-01-09 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Show display name iso email address (1.41 KB, patch)
2004-12-27 19:21 UTC, Olav Vitters
committed Details | Review
Also show display name in diffs (1.24 KB, patch)
2004-12-27 19:38 UTC, Olav Vitters
committed Details | Review

Description Christian Persch 2004-12-15 14:48:04 UTC
In bugmails, the commenter's email is displayed instead of his real name, like this:

------- Additional Comments From chpe@gnome.org  2004-12-15 08:51 -------
instead of
------- Additional Comment #3 From Christian Persch  2004-12-15 08:51 -------

I think not displaying the email address will address the following problem: bug
submitters keep replying directly to me, instead of adding their comment to
bugzilla.
Comment 1 Elijah Newren 2004-12-15 19:04:49 UTC
Agreed.  We also need the all-caps "DO NOT RESPOND TO THIS EMAIL.  GO TO <URL>
AND ADD YOUR COMMENTS THERE" at the beginning of each email.  :-)
Comment 2 Olav Vitters 2004-12-27 19:21:56 UTC
Created attachment 35233 [details] [review]
Show display name iso email address

Patch changes the GetLongDescriptionAsText function in globals.pl to display
the real name if it is set. This function is only used in processmail. Adding
the comment number is hard to do, so this patch doesn't do that.

Additional text at the beginning of the email can be configured by the
'newchangedmail' Bugzilla parameter.

This patch also doesn't change the 'bugzilla-gnome@bkor.dhs.org changed:'
(shown when changing fields, confirming a bug, etc). I'll do that in a separate
patch.
Comment 3 Olav Vitters 2004-12-27 19:38:21 UTC
Created attachment 35234 [details] [review]
Also show display name in diffs

This is a separate patch.

This will show the name when changing fields (the 'user@example.com changed:').


Example (currently):
user@example.com changed:

	   What    |Removed			|Added
----------------------------------------------------------------------------
	 OS/Version|Linux			|All

Example (after the patch and realname filled in):
John Doe changed:

	   What    |Removed			|Added
----------------------------------------------------------------------------
	 OS/Version|Linux			|All

Note that when adding/removing an email address (CC field) it will still show
that email address in the 'Removed' or 'Added' parts.
Comment 4 Andrew Sobala 2005-01-09 00:36:24 UTC
Please apply then retest.
Comment 5 Olav Vitters 2005-01-09 14:05:47 UTC
Have committed and retested on test bug 162691.

Changed status and added comment with realname set -- realname was correctly
shown in email. Cleared realname in preference. Again changed status and added
comment -- shows email address.

Marking fixed.