GNOME Bugzilla – Bug 161352
Build fails under AIX
Last modified: 2006-01-16 12:41:00 UTC
When compiling vte/src/vte.c and vte/src/vteregex.c under AIX with IBM's own C compiler (Visual Age compiler version 6.0), the build fails because the header file "config.h" is included twice. In fact "config.h" header files does not have any mechanism to avoid being included more than once as opposed as most .h files. The problem here comes from the fact that the config.h file is included by vteregex.h when this is not necessary because the 2 source files including vteregex.h already include config.h Would it be possible to submit into CVS the simple following patch (consisiting of removing the unnecessary inclusion of config.h by vteregex.h) ? ----------------------- Start of patch ----------------- --- vte/src/vteregex.h.old 2004-12-15 11:32:01.000000000 +0100 +++ vte/src/vteregex.h 2004-12-15 11:33:17.000000000 +0100 @@ -19,9 +19,8 @@ #ifndef vte_vteregex_h_included #define vte_vteregex_h_included -#ident "$Id: vteregex.h,v 1.1 2003/07/10 20:38:11 nalin Exp $" +#ident "$Id: vteregex.h,v 1.1.3.2 2004/11/09 10:43:31 bergerv Exp $" -#include "../config.h" #include <glib.h> G_BEGIN_DECLS ------------------------- End of Patch --------------------------- Thanks for taking this into account. Vincent.
I'll commit this. Compile fix, and headers shouldn't include config.h anyways since that can cause problems for localisation since it means config.h isn't included as the first file in .c files that include vteregex.h.
Vincent is not in the project anymore. Please make me "opener" of the defect in case someone reopens it : jean-pierre.dion@bull.net Thanks. jean-pierre