GNOME Bugzilla – Bug 161039
[PATCH] [deinterlace] rowstrides need fixing
Last modified: 2004-12-22 21:47:04 UTC
deinterlace needs rowstride fixing for odd widths. Patch attached. Cheers -Tim
Created attachment 34741 [details] [review] proposed fix
How about we put those macros in gst-plugins/gst-libs/gst/video/video.h so that all video plugins can share them? Saves some duplication...
There was some talk several months ago about defining a struct and writing a few functions that would take a GstCaps (or equivalent) and returning a struct with lots of calculated information, like rowstrides, U and V pointers, pixel strides, subsampling, etc. It obviously never got anywhere, but it's a good idea.
OK, we'll leave that for the time being, since it's not going anywhere and the patch is good otherwise. I would like people to look at generalizing those macros in a general header at some point, though. Apart from that, patch applied.