After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 161039 - [PATCH] [deinterlace] rowstrides need fixing
[PATCH] [deinterlace] rowstrides need fixing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
git master
Other Linux
: Normal normal
: 0.8.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-11 19:20 UTC by Tim-Philipp Müller
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (2.09 KB, patch)
2004-12-11 19:20 UTC, Tim-Philipp Müller
none Details | Review

Description Tim-Philipp Müller 2004-12-11 19:20:08 UTC
deinterlace needs rowstride fixing for odd widths. Patch attached. 
 
Cheers 
 -Tim
Comment 1 Tim-Philipp Müller 2004-12-11 19:20:52 UTC
Created attachment 34741 [details] [review]
proposed fix
Comment 2 Ronald Bultje 2004-12-16 23:35:55 UTC
How about we put those macros in gst-plugins/gst-libs/gst/video/video.h so that
all video plugins can share them? Saves some duplication...
Comment 3 David Schleef 2004-12-16 23:41:00 UTC
There was some talk several months ago about defining a struct and writing a few
functions that would take a GstCaps (or equivalent) and returning a struct with
lots of calculated information, like rowstrides, U and V pointers, pixel
strides, subsampling, etc.  It obviously never got anywhere, but it's a good idea.
Comment 4 Ronald Bultje 2004-12-18 23:41:49 UTC
OK, we'll leave that for the time being, since it's not going anywhere and the
patch is good otherwise. I would like people to look at generalizing those
macros in a general header at some point, though.

Apart from that, patch applied.