After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 160756 - patch which add --disable-demos to configure script
patch which add --disable-demos to configure script
Status: RESOLVED NOTABUG
Product: gtkmm
Classification: Bindings
Component: build
unspecified
Other Linux
: Low minor
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2004-12-08 09:03 UTC by Plors (Bart H)
Modified: 2005-01-25 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to alter toplevel Makefile.am (384 bytes, patch)
2004-12-08 09:04 UTC, Plors (Bart H)
none Details | Review
patch to alter configure.in (583 bytes, patch)
2004-12-08 09:04 UTC, Plors (Bart H)
none Details | Review

Description Plors (Bart H) 2004-12-08 09:03:13 UTC
--disable-examples shaves of 50% of the total buildtime. This is great but the
stuff in demo/ still gets build.

I patched configure.in and Makefile.am to add a --disable-demos option
which does exactly as it says. Patches are diffs against latest (2.4.8)
files.

WHY do i want this? i first came across this while creating a gtkmm ebuild for
gentoo. Since none of the examples and demos are installed it seems a waste of
time to build them.
Comment 1 Plors (Bart H) 2004-12-08 09:04:00 UTC
Created attachment 34622 [details] [review]
patch to alter toplevel Makefile.am
Comment 2 Plors (Bart H) 2004-12-08 09:04:34 UTC
Created attachment 34623 [details] [review]
patch to alter configure.in
Comment 3 Murray Cumming 2004-12-16 19:33:40 UTC
Thanks, but I think that it's a very good idea to always have some sanity-checks
in the build, and I don't think the demos take so long compared to the examples.
I also don't consider this very important because people shouldn't build from
source unless they are packagers or testers.

If you are a packager of a sensible distro then I might change my mind.
Comment 4 Plors (Bart H) 2004-12-17 15:41:36 UTC
Aren't some sanity-checks already performed in tests/ ? 
And indeed the demos don't take so long, to compile, but they still take up some
8 min from ~20 min total buildtime.

Also they're (just like the examples) enabled by default, so if anyone disables
them it's his own responsibility.

Anyway, it's not that important, i just thought i'd be a 'small gain, no pain'
situation :)
Comment 5 Murray Cumming 2004-12-18 15:17:04 UTC
> Aren't some sanity-checks already performed in tests/ ?

Not enough, in my opinion.
Comment 6 Murray Cumming 2005-01-25 13:09:16 UTC
Actually, I have applied this because the demos do not compile on AIX, and I
don't want to work around the problems just for AIX.

In future, please create a real cvs patch, and patch the ChangeLog.
http://www.gtkmm.org/bugs.shtml#CreatingPatches

Thanks.