GNOME Bugzilla – Bug 160535
allow jhbuildrc to override make command
Last modified: 2005-05-14 19:14:47 UTC
This patch adds a "make" config variable, defaulting to "make". This lets you configure jhbuild to use GNU make rather than the system make on non-Linux OSes, since various GNOME packages use GNU-make-specific features.
Created attachment 34516 [details] [review] patch
Rather than adding a new config key, wouldn't it make more sense to use the $MAKE environment variable? The user can set it in their config file by assigning to os.environ['MAKE'], and you can get the value using os.environ.get('MAKE', 'make').
Created attachment 34839 [details] [review] revised patch using $MAKE OK, here's a patch that does it that way
Looks like I forgot about this bug. The patch looks okay, so feel free to apply it.
Whenever someone gets around applying this (patch still applies cleanly modulo ChangeLog), it'd be nice to add an example in sample.jhbuildrc along these lines: --- sample.jhbuildrc.orig 2005-04-10 14:07:30.863633784 +0200 +++ sample.jhbuildrc 2005-04-10 14:08:10.250646048 +0200 @@ -27,6 +27,9 @@ # set CFLAGS: #os.environ['CFLAGS'] = '-g -O2' +# On SMP systems you may use something like this to improve compilation time: +#os.environ['MAKE'] = 'make -j2' + # a alternative install program to use. # The included install-check program won't update timestamps if the # header hasn't changed
Committed as patch had status accept-commit_now for a while now. Also added the example suggested by Michele Baldessari (separate commit). Marking FIXED.