After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 160467 - Rephrase low-battery warning and make selectable
Rephrase low-battery warning and make selectable
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: battery
git master
Other All
: Normal normal
: 2.10
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2004-12-05 00:27 UTC by Adam Hooper
Modified: 2005-05-24 13:43 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
proposed patch (2.21 KB, patch)
2005-05-16 04:43 UTC, Allison Karlitskaya (desrt)
none Details | Review

Description Adam Hooper 2004-12-05 00:27:02 UTC
Currently, the low-battery warning is phrased like this:

"16 minutes (15%) remaining. To avoid losing work please power off, suspend or
plug your laptop in."

It ends with a preposition and the one comma disrupts the flow of the sentence.
Pedantic, I know, but I think the following would be better:

"16 minutes (15%) battery power remaining. Power off, suspend, or plug in your
laptop to avoid losing work."

The text in the warning isn't selectable, either.

Oh, and one last thing: wouldn't it be cool if there were "Suspend" and "Power
off" buttons on that alert?
Comment 1 Danielle Madeley 2004-12-05 01:29:05 UTC
CCing Usability for both points.

From a technical aspect with the second one. Powering off/suspending the system
is difficult as an ordinary user. I'll have to check how this is achieved in
gdm... but I suspect that I will not like the answer.

Realistically this is a job for the hypothetical PowerManager
(http://live.gnome.org/PowerManager) (gdm should also use the same solution).
Comment 2 Calum Benson 2004-12-17 16:36:30 UTC
I agree Adam's proposed wording is better (although I prefer the less geeky
"switch off" to "power off").  You could argue that powering off your laptop
isn't necessarily going to save any more of your work than your battery suddenly
dying, though-- when I press the power button on my laptop, it shuts down
cleanly, but it still doesn't save any documents I had open at the time.  So
perhaps "plug in or suspend" are the only two options we should really mention here?
Comment 3 Christoffer Olsen 2005-01-04 00:11:36 UTC
Though we're waiting for a PowerManager, I guess this should be fixed in the
meantime. Assigning bug, looking at it later.
Comment 4 Danielle Madeley 2005-01-04 03:12:38 UTC
Chris, three things to work on.
 - Reword the dialog,
 - Make the text selectable, and
 - Stop [OK] being the default button.

At the moment, when you're typing you can space or enter through the dialog when
it pops up. Ideally you should either have to click, or press Tab->Enter.
Comment 5 Allison Karlitskaya (desrt) 2005-05-16 04:43:42 UTC
Created attachment 46472 [details] [review]
proposed patch

1) "15 minutes (5%) battery power remaining.  To avoid losing work, suspend,
plug in or save open documents and switch off your laptop."

2) text is now selectable

3) the issue of accidentally hitting space or enter and clearing the dialog has
been resolved by davyd's patches to cause the dialog to pop on top but not
steal focus.
Comment 6 Allison Karlitskaya (desrt) 2005-05-18 13:19:04 UTC
Commited patch with slight modification: "15 minutes (5%) battery power
remaining" is now "15 minutes (5%) of battery power remaining".
Comment 7 Calum Benson 2005-05-23 16:22:46 UTC
Hmm, how do I suspend or plug in my open documents?  :)  Should really be
something like "suspend or plug in your laptop, or save open documents and
switch off your laptop".
Comment 8 Allison Karlitskaya (desrt) 2005-05-23 16:28:06 UTC
Is there any possible way to avoid saying "your laptop" twice?
Comment 9 Adam Hooper 2005-05-23 16:46:43 UTC
Why not just forget about mentioning open documents? Trying to switch off your
laptop ought to pop up all sorts of "quit confirmation" dialogs on open
documents. (I don't know if it *does* or not, but even if it doesn't, I think
everybody saves documents before shutting down.)
Comment 10 Calum Benson 2005-05-24 12:47:04 UTC
> Is there any possible way to avoid saying "your laptop" twice? 

Hmm, well, I guess you could say something like "suspend or plug in your laptop, or save open 
documents before switching it off" instead.  But my recollection is that the docs styleguide advises 
against using impersonal pronouns wherever possible, for ease of translation.  Cc'ing Eugene for any 
better ideas, before he disappears :/

> Trying to switch off your laptop ought to pop up all sorts of "quit confirmation" dialogs on open
documents.

Indeed it should, but as yet it doesn't AFAIK.  (I don't think Linux has the kernel support for that sort of 
thing ATM, but I could be wrong...)
Comment 11 Adam Hooper 2005-05-24 13:14:33 UTC
>> Trying to switch off your laptop ought to pop up all sorts of "quit
confirmation" dialogs on open
documents.

>Indeed it should, but as yet it doesn't AFAIK.  (I don't think Linux has the
kernel support for that sort of 
thing ATM, but I could be wrong...)

It'd be the session manager's responsibility, not the kernel's.
Comment 12 Calum Benson 2005-05-24 13:22:50 UTC
Only if the session manager ever gets to know about it-- when I press the power switch on my Dell laptop, 
it just switches straight off when I'm running Linux.  (Windows shuts down gracefully.)
Comment 13 Eugene O'Connor 2005-05-24 13:43:27 UTC
I just want to tease out a little bit exactly what is going on before making a
recommendation. What we are saying is that, to avoid losing data in unsaved
documents, the user must do one of the following:

- Suspend your laptop
- Plug in your laptop
- Save all open documents, then switch off your laptop

A couple of questions:

1. What exactly does suspend do? Does the laptop enter a particular mode? Is
data saved to the hard disk, and then the system switched off?
2. In the third option above, is the "then switch off your laptop" redundant?
The user has already saved all open documents. What are we really asking the
user to do? Save all open documents, or restore the laptop to a state where lack
of power is not a threat to the functioning of the laptop.