After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 160376 - gtkimcontextime.c: double commit bug and ctrl key disregard
gtkimcontextime.c: double commit bug and ctrl key disregard
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.5.x
Other All
: High major
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2004-12-03 20:11 UTC by Kazuki Iwamoto
Modified: 2011-02-04 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This actually happens. (48.07 KB, image/jpeg)
2004-12-03 20:13 UTC, Kazuki Iwamoto 		  Details
patch for gtkimcontextime.c (558 bytes, patch)
2004-12-03 20:16 UTC, Kazuki Iwamoto 		accepted-commit_now Details | Review

Description Kazuki Iwamoto 2004-12-03 20:11:00 UTC 
Please describe the problem:
1. double commit bug
When use_preedit is FALSE, "commit" signal is emitted doubly.
First time, "commit" signal which has all characters is emitted in
gtk_im_context_ime_message_filter.
After it, "commit" signals are emitted every character in
gtk_im_context_ime_filter_keypress.
(If use_preedit is TRUE / default, this bug does not occur.)

2. ctrl key disregard
When a key with Ctrl is pushed, "commit" signal is emitted.
For example, if Crtl+z is pushed, "commit" signal which has "z" is emitted.


Steps to reproduce:
1. use Windows IME and push Ctrl+Z

Actual results:
(Please see attached jpeg file.)


Expected results:
If emitted in gtk_im_context_ime_message_filter,
it is not emitted in gtk_im_context_ime_filter_keypress.
And if (event->state & GDK_CONTROL_MASK) is true,
"commit" signal is not emitted in gtk_im_context_ime_filter_keypress.


Does this happen every time?
every time

Other information:
Comment 1 Kazuki Iwamoto 2004-12-03 20:13:31 UTC 
Created attachment 34465 [details]
This actually happens.
Comment 2 Kazuki Iwamoto 2004-12-03 20:16:57 UTC 
Created attachment 34466 [details] [review]
patch for gtkimcontextime.c
Comment 3 Matthias Clasen 2004-12-04 03:08:44 UTC 
Comment on attachment 34466 [details] [review]
patch for gtkimcontextime.c

looks good to me
Comment 4 Matthias Clasen 2004-12-06 05:22:04 UTC 
2004-12-06  Matthias Clasen  <mclasen@redhat.com>

	* modules/input/gtkimcontextime.c: Prevent double commits,
	don't commit when Ctrl is present.  (#160376, Kazuki IWAMOTO)