After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 160163 - (locations-love) [umbrella] Locations Love
(locations-love)
[umbrella] Locations Love
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: locations
unspecified
Other All
: Normal normal
: 2.24.0
Assigned To: libgweather-maint
libgweather-maint
Depends on: 155202 159899 159930 160007 160135 160426 160909 160981 161093 161094 161096 161097 161100 161590 161708 162737 163732 164034 164529 165016 166014 166762 166913 168527 305712 306265 308269 313655 326282 329155 333175 335135 337305 337900 340712 343779 344155 345357 350480 350945
Blocks: 321411 325820 327143
 
 
Reported: 2004-12-02 03:40 UTC by Danielle Madeley
Modified: 2008-11-30 09:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
Cleans up London, UK using the <city> tag (1.66 KB, patch)
2005-01-09 13:03 UTC, Nicholas Skehin
committed Details | Review
Thailand Locations Reorganizing (4.24 KB, patch)
2005-05-07 15:38 UTC, Theppitak Karoonboonyanan
committed Details | Review
adds bordj el amri, nefta and formiga to Locations.xml (1.22 KB, patch)
2006-01-11 15:46 UTC, Mohammed Adnène Trojette
needs-work Details | Review
new patch for bordj,nefta and formiga (1.35 KB, patch)
2006-02-25 14:23 UTC, Thierry Moisan
committed Details | Review

Description Danielle Madeley 2004-12-02 03:40:23 UTC
These are bugs from the gweather Locations Love-in.

http://mail.gnome.org/archives/gnome-love/2004-November/msg00030.html
Comment 1 Nicholas Skehin 2005-01-09 13:03:10 UTC
Created attachment 35722 [details] [review]
Cleans up London, UK using the <city> tag

Tested with patch -p0 < london-diff.patch
Comment 2 Theppitak Karoonboonyanan 2005-05-07 15:38:04 UTC
Created attachment 46132 [details] [review]
Thailand Locations Reorganizing

This patch reorganizes locations in Thailand by city names. (Note: New string
"Bangkok" introduced.)
Comment 3 Danielle Madeley 2005-06-09 08:52:51 UTC
Looks fine. Make sure it passes xmllint before committing.
Comment 4 Theppitak Karoonboonyanan 2005-06-09 13:53:58 UTC
Comment on attachment 46132 [details] [review]
Thailand Locations Reorganizing

Patch committed to HEAD.
Comment 5 Mohammed Adnène Trojette 2006-01-11 15:46:47 UTC
Created attachment 57162 [details] [review]
adds bordj el amri, nefta and formiga to Locations.xml

This patch adds bordj el amri, nefta (Tunisia) and formiga (Brasil) to Locations.xml
Comment 6 Danielle Madeley 2006-01-12 04:05:30 UTC
Comment on attachment 57162 [details] [review]
adds bordj el amri, nefta and formiga to Locations.xml

These changes should be to Locations.xml.in which you can get from the CVS repository.
Comment 7 Daniel Holbach 2006-01-23 14:34:37 UTC
Comment from https://launchpad.net/distros/ubuntu/+source/gnome-applets/+bug/29422

In the Weather applet, people in Helsinki can choose from the Malmi (located in a Northern suburb) or Vantaa (international airport in the North). There is a weather station in the center of the city, which should be added.
Station details:
Name - Kaisaniemi
WMO - 02978
LPNN - 0304
Comment 8 Thierry Moisan 2006-02-25 14:03:00 UTC
I wanted to add the Kaisaniemi station but I couldn't find the international code wich is needed. At least I got the coordinates from  http://www.fmi.fi/weather/stations_36.html
It's 60-10N 024-56E
Comment 9 Thierry Moisan 2006-02-25 14:23:54 UTC
Created attachment 60107 [details] [review]
new patch for bordj,nefta and formiga

I simply added the stuff from the last patch to Locations.xml.in
Comment 10 jsiltala 2006-03-01 12:52:38 UTC
(In reply to comment #8)
> I wanted to add the Kaisaniemi station but I couldn't find the international
> code wich is needed. At least I got the coordinates from 

I looked a bit closer and found that automated station at Kaisaniemi has been discontinued since 2001, and cannot be added. There is now only a manned station which reports twice a day.
http://ilmatieteenlaitos.fi/saa/havainto_51.html
Comment 11 Florian Steinel 2006-07-02 19:41:29 UTC
see http://weather.noaa.gov/data/nsd_cccc.txt for all avaible ICAO codes.
Comment 12 Daniel Holbach 2006-10-30 11:30:51 UTC
https://launchpad.net/distros/ubuntu/+source/gnome-applets/+bug/69115 complains about Jerusalem, Israel missing in gnome-applets 2.16.1:

"Add Weather applet to panel
Open Preferences
Try to find Jerusalem, Israel

It's gone!
It was there in the previous version."
Comment 13 era+gnome 2008-04-08 20:59:45 UTC
Regarding the Helsinki locations (comment #7 and followups);

The reaction I and several of my colleagues had was that this is just weird and wrong. It's not like this is a huge city anyway. I think there should only be a Helsinki item, and Vantaa (which is a separate municipality anyway) should be listed as a separate city. You really don't want to see the implementation detail and if you do see it, you don't particularly want either of these two options.

My suggestion: move Finland/Vantaa to a separate item and use Finland/Helsinki for the Malmi station.
Comment 14 Pavel Šefránek 2008-04-26 22:02:50 UTC
Everything's done!
Comment 15 Dan Winship 2008-06-18 17:34:53 UTC
Moving libgweather-specific bugs out of gweather-applet
Comment 16 Dan Winship 2008-11-30 00:54:45 UTC
I'm calling this old bug fixed. People who want to help fix the current list of locations should look at http://live.gnome.org/LibGWeather/ImprovingLocations and file new bugs (or finish up the existing NEEDINFO bugs)
Comment 17 era+gnome 2008-11-30 09:16:41 UTC
I submitted http://bugzilla.gnome.org/show_bug.cgi?id=562742 for the Finland issue.
Comment 18 era+gnome 2008-11-30 09:20:16 UTC
For the record, the London patch appears to be obsolete.  London UK is tagged as a city, featuring the City, Heathrow, and Gatwick weather stations, with Stansted Moutfitchet listed as a separate city.
Comment 19 era+gnome 2008-11-30 09:21:49 UTC
I'm not competent to judge the Thailand patch, but I note that Bangkok is in the current trunk, so that patch is probably also at least outdated, if not completely obsolete.
Comment 20 era+gnome 2008-11-30 09:25:57 UTC
The Tunisian and Brazilian locations from patch 60107 are not in the current trunk, but I'm guessing they have been removed after they were committed.

Didn't notice the Thailand and London patches were already marked as "committed".
Comment 21 era+gnome 2008-11-30 09:33:53 UTC
Updated bug #561662 (Israel locations) with a mention that Jerusalem should be added, too.